From: Liang He <windhl@126.com>
To: agust@denx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, ulia.Lawall@inria.fr, nick.child@ibm.com
Cc: windhl@126.com, linuxppc-dev@lists.ozlabs.org, joel@jms.id.au,
linux-kernel@vger.kernel.org
Subject: [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put()
Date: Wed, 15 Jun 2022 22:37:03 +0800 [thread overview]
Message-ID: <20220615143703.3968898-1-windhl@126.com> (raw)
In mpc5121_clk_init(), of_find_compatible_node() will return a
node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/powerpc/platforms/512x/clock-commonclk.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c
index 0652c7e69225..ca475462e95b 100644
--- a/arch/powerpc/platforms/512x/clock-commonclk.c
+++ b/arch/powerpc/platforms/512x/clock-commonclk.c
@@ -1208,6 +1208,8 @@ int __init mpc5121_clk_init(void)
/* register as an OF clock provider */
mpc5121_clk_register_of_provider(clk_np);
+ of_node_put(clk_np);
+
/*
* unbreak not yet adjusted peripheral drivers during migration
* towards fully operational common clock support, and allow
--
2.25.1
next reply other threads:[~2022-06-16 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:37 Liang He [this message]
2022-09-09 12:07 ` [PATCH] arch: powerpc: platforms: 512x: Add missing of_node_put() Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615143703.3968898-1-windhl@126.com \
--to=windhl@126.com \
--cc=agust@denx.de \
--cc=benh@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nick.child@ibm.com \
--cc=paulus@samba.org \
--cc=ulia.Lawall@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).