* [PATCH 0/2] powerpc/32: nohz full support
@ 2022-10-06 14:22 Nicholas Piggin
2022-10-06 14:22 ` [PATCH 1/2] powerpc/32: implement HAVE_CONTEXT_TRACKING_USER support Nicholas Piggin
2022-10-06 14:23 ` [PATCH 2/2] powerpc/32: select HAVE_VIRT_CPU_ACCOUNTING_GEN Nicholas Piggin
0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Piggin @ 2022-10-06 14:22 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
On top of the previous fix to prevent KVM being selected with
context tracking on 32-bit, this should be good to go.
Since RFC:
- Improved code sharing in interrupt.h
- Minimal patch for VIRT_CPU_ACCOUNTING_GEN support
Thanks,
Nick
Nicholas Piggin (2):
powerpc/32: implement HAVE_CONTEXT_TRACKING_USER support
powerpc/32: select HAVE_VIRT_CPU_ACCOUNTING_GEN
arch/powerpc/Kconfig | 3 ++-
arch/powerpc/include/asm/interrupt.h | 35 +++++++---------------------
2 files changed, 10 insertions(+), 28 deletions(-)
--
2.37.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] powerpc/32: implement HAVE_CONTEXT_TRACKING_USER support
2022-10-06 14:22 [PATCH 0/2] powerpc/32: nohz full support Nicholas Piggin
@ 2022-10-06 14:22 ` Nicholas Piggin
2022-10-06 14:23 ` [PATCH 2/2] powerpc/32: select HAVE_VIRT_CPU_ACCOUNTING_GEN Nicholas Piggin
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas Piggin @ 2022-10-06 14:22 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
Context tracking involves tracking user, kernel, guest switches. This
enables existing context tracking code for interrupt entry on 32-bit.
interrupt exit already has context tracking calls, and KVM can not be
selected if CONTEXT_TRACKING_USER=y.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/Kconfig | 2 +-
arch/powerpc/include/asm/interrupt.h | 35 +++++++---------------------
2 files changed, 9 insertions(+), 28 deletions(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 81c9f895d690..f667279ec74c 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -204,7 +204,7 @@ config PPC
select HAVE_ARCH_SECCOMP_FILTER
select HAVE_ARCH_TRACEHOOK
select HAVE_ASM_MODVERSIONS
- select HAVE_CONTEXT_TRACKING_USER if PPC64
+ select HAVE_CONTEXT_TRACKING_USER
select HAVE_C_RECORDMCOUNT
select HAVE_DEBUG_KMEMLEAK
select HAVE_DEBUG_STACKOVERFLOW
diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/asm/interrupt.h
index 4745bb9998bd..f88a145fb61a 100644
--- a/arch/powerpc/include/asm/interrupt.h
+++ b/arch/powerpc/include/asm/interrupt.h
@@ -74,17 +74,18 @@
#include <asm/kprobes.h>
#include <asm/runlatch.h>
-#ifdef CONFIG_PPC64
+#ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG
/*
* WARN/BUG is handled with a program interrupt so minimise checks here to
* avoid recursion and maximise the chance of getting the first oops handled.
*/
#define INT_SOFT_MASK_BUG_ON(regs, cond) \
do { \
- if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG) && \
- (user_mode(regs) || (TRAP(regs) != INTERRUPT_PROGRAM))) \
+ if ((user_mode(regs) || (TRAP(regs) != INTERRUPT_PROGRAM))) \
BUG_ON(cond); \
} while (0)
+#else
+#define INT_SOFT_MASK_BUG_ON(regs, cond)
#endif
#ifdef CONFIG_PPC_BOOK3S_64
@@ -151,28 +152,8 @@ static inline void booke_restore_dbcr0(void)
static inline void interrupt_enter_prepare(struct pt_regs *regs)
{
-#ifdef CONFIG_PPC32
- if (!arch_irq_disabled_regs(regs))
- trace_hardirqs_off();
-
- if (user_mode(regs))
- kuap_lock();
- else
- kuap_save_and_lock(regs);
-
- if (user_mode(regs))
- account_cpu_user_entry();
-#endif
-
#ifdef CONFIG_PPC64
- bool trace_enable = false;
-
- if (IS_ENABLED(CONFIG_TRACE_IRQFLAGS)) {
- if (irq_soft_mask_set_return(IRQS_ALL_DISABLED) == IRQS_ENABLED)
- trace_enable = true;
- } else {
- irq_soft_mask_set(IRQS_ALL_DISABLED);
- }
+ irq_soft_mask_set(IRQS_ALL_DISABLED);
/*
* If the interrupt was taken with HARD_DIS clear, then enable MSR[EE].
@@ -188,9 +169,10 @@ static inline void interrupt_enter_prepare(struct pt_regs *regs)
} else {
__hard_RI_enable();
}
+ /* Enable MSR[RI] early, to support kernel SLB and hash faults */
+#endif
- /* Do this when RI=1 because it can cause SLB faults */
- if (trace_enable)
+ if (!arch_irq_disabled_regs(regs))
trace_hardirqs_off();
if (user_mode(regs)) {
@@ -215,7 +197,6 @@ static inline void interrupt_enter_prepare(struct pt_regs *regs)
}
INT_SOFT_MASK_BUG_ON(regs, !arch_irq_disabled_regs(regs) &&
!(regs->msr & MSR_EE));
-#endif
booke_restore_dbcr0();
}
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] powerpc/32: select HAVE_VIRT_CPU_ACCOUNTING_GEN
2022-10-06 14:22 [PATCH 0/2] powerpc/32: nohz full support Nicholas Piggin
2022-10-06 14:22 ` [PATCH 1/2] powerpc/32: implement HAVE_CONTEXT_TRACKING_USER support Nicholas Piggin
@ 2022-10-06 14:23 ` Nicholas Piggin
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas Piggin @ 2022-10-06 14:23 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
cputime_t is no longer a type, so VIRT_CPU_ACCOUNTING_GEN does not
have any affect on the type for 32-bit architectures, so there is
no reason it can't be supported.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index f667279ec74c..a6e1ba506b72 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -252,6 +252,7 @@ config PPC
select HAVE_STATIC_CALL if PPC32
select HAVE_SYSCALL_TRACEPOINTS
select HAVE_VIRT_CPU_ACCOUNTING
+ select HAVE_VIRT_CPU_ACCOUNTING_GEN
select HUGETLB_PAGE_SIZE_VARIABLE if PPC_BOOK3S_64 && HUGETLB_PAGE
select IOMMU_HELPER if PPC64
select IRQ_DOMAIN
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-06 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 14:22 [PATCH 0/2] powerpc/32: nohz full support Nicholas Piggin
2022-10-06 14:22 ` [PATCH 1/2] powerpc/32: implement HAVE_CONTEXT_TRACKING_USER support Nicholas Piggin
2022-10-06 14:23 ` [PATCH 2/2] powerpc/32: select HAVE_VIRT_CPU_ACCOUNTING_GEN Nicholas Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).