From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/64s: POWER10 CPU Kconfig build option
Date: Thu, 6 Oct 2022 14:54:11 -0500 [thread overview]
Message-ID: <20221006195411.GS25951@gate.crashing.org> (raw)
In-Reply-To: <20220923033004.536127-1-npiggin@gmail.com>
Hi!
On Fri, Sep 23, 2022 at 01:30:04PM +1000, Nicholas Piggin wrote:
> This adds basic POWER10_CPU option, which builds with -mcpu=power10.
> +# No prefix or pcrel
> +KBUILD_CFLAGS += $(call cc-option,-mno-prefixed)
> +KBUILD_CFLAGS += $(call cc-option,-mno-pcrel)
Why do you disable all prefixed insns? What goes wrong if you don't?
Same question for pcrel. I'm sure you want to optimise it better, but
it's not clear to me how it fails now?
Please say in the comment what is wrong, don't spread fear :-)
> +# No AltiVec or VSX or MMA instructions when building kernel
> KBUILD_CFLAGS += $(call cc-option,-mno-altivec)
> KBUILD_CFLAGS += $(call cc-option,-mno-vsx)
> +KBUILD_CFLAGS += $(call cc-option,-mno-mma)
MMA code is never generated unless the code asks for it explicitly.
This is fundamental, not just an implementations side effect.
Segher
next prev parent reply other threads:[~2022-10-06 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 3:30 [PATCH] powerpc/64s: POWER10 CPU Kconfig build option Nicholas Piggin
2022-09-23 5:46 ` Christophe Leroy
2022-09-23 6:23 ` Nicholas Piggin
2022-10-06 18:07 ` Christophe Leroy
2022-10-06 20:15 ` Segher Boessenkool
2022-10-06 22:03 ` Nicholas Piggin
2022-10-10 3:41 ` Nicholas Piggin
2022-10-04 13:25 ` Michael Ellerman
2022-10-06 19:54 ` Segher Boessenkool [this message]
2022-10-06 21:56 ` Nicholas Piggin
2022-10-06 23:23 ` Segher Boessenkool
2022-10-07 0:03 ` Nicholas Piggin
2022-10-07 5:31 ` Michael Ellerman
2022-10-07 14:38 ` Segher Boessenkool
2022-10-07 14:57 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006195411.GS25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).