From: "Pali Rohár" <pali@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Sinan Akman <sinan@writeme.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Scott Wood <oss@buserror.net>, Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Date: Wed, 2 Nov 2022 00:25:03 +0100 [thread overview]
Message-ID: <20221101232503.qymzj7dypsehafvj@pali> (raw)
In-Reply-To: <3111f16b-2e6d-c46f-67e9-6cb5fada4cc7@csgroup.eu>
On Sunday 16 October 2022 16:59:53 Christophe Leroy wrote:
> Hello,
>
> Le 16/10/2022 à 13:05, Pali Rohár a écrit :
> > Hello Christophe! Do you have any other comments for this patch series?
>
> I'm AFK for two weeks, but as far as I remember I don't have any more
> comments.
Hello! When you are back, could you look at my feedback to your comments?
> >
> > On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
> >> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
> >>> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> >>>> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> >>>>
> >>>> Signed-off-by: Pali Rohár <pali@kernel.org>
> >>>
> >>> This patch should be squashed into patch 1.
> >>
> >> No problem. Just to explain that I split those changes into different
> >> patches because they touch different files and different board code.
> >> And I thought that different things should be in different patches.
> >>
> >>>> ---
> >>>> arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> index f8d2c97f39bd..9a6d637ef54a 100644
> >>>> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
> >>>> }
> >>>> #endif /* CONFIG_PPC_I8259 */
> >>>>
> >>>> -void __init mpc85xx_ds_pic_init(void)
> >>>> +static void __init mpc85xx_ds_pic_init(void)
> >>>> {
> >>>> struct mpic *mpic;
> >>>> #ifdef CONFIG_PPC_I8259
next prev parent reply other threads:[~2022-11-01 23:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:15 [PATCH 0/7] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2022-08-19 19:15 ` [PATCH 1/7] powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static Pali Rohár
2022-08-19 19:15 ` [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() " Pali Rohár
2022-09-26 9:43 ` Christophe Leroy
2022-09-26 9:47 ` Pali Rohár
2022-10-16 11:05 ` Pali Rohár
2022-10-16 16:59 ` Christophe Leroy
2022-11-01 23:25 ` Pali Rohár [this message]
2022-11-26 16:25 ` Pali Rohár
2022-12-02 18:46 ` Christophe Leroy
2022-08-19 19:15 ` [PATCH 3/7] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c Pali Rohár
2022-09-26 9:48 ` Christophe Leroy
2022-09-26 9:53 ` Pali Rohár
2022-09-26 10:17 ` Christophe Leroy
2022-09-26 10:26 ` Pali Rohár
2022-12-07 14:02 ` Christophe Leroy
2022-08-19 19:15 ` [PATCH 4/7] powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks Pali Rohár
2022-09-26 9:59 ` Christophe Leroy
2022-08-19 19:15 ` [PATCH 5/7] powerpc/85xx: p2020: Define just one machine description Pali Rohár
2022-09-26 10:02 ` Christophe Leroy
2022-09-26 10:08 ` Pali Rohár
2022-08-19 19:15 ` [PATCH 6/7] powerpc/85xx: p2020: Enable boards by new config option CONFIG_P2020 Pali Rohár
2022-09-26 10:08 ` Christophe Leroy
2022-09-26 10:19 ` Pali Rohár
2022-08-19 19:15 ` [PATCH 7/7] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string Pali Rohár
2022-09-26 10:10 ` Christophe Leroy
2022-09-26 10:21 ` Pali Rohár
2022-09-24 12:42 ` [PATCH 0/7] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2022-12-04 10:54 ` Pali Rohár
2022-12-07 14:07 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101232503.qymzj7dypsehafvj@pali \
--to=pali@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=sinan@writeme.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).