From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: michel@lespinasse.org, joelaf@google.com, songliubraving@fb.com,
mhocko@suse.com, leewalsh@google.com, david@redhat.com,
peterz@infradead.org, bigeasy@linutronix.de, peterx@redhat.com,
dhowells@redhat.com, linux-mm@kvack.org, edumazet@google.com,
jglisse@google.com, punit.agrawal@bytedance.com,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
will@kernel.org, arjunroy@google.com, chriscli@google.com,
dave@stgolabs.net, minchan@google.com, x86@kernel.org,
hughd@google.com, willy@infradead.org, gurua@google.com,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org,
rientjes@google.com, axelrasmussen@google.com,
kernel-team@android.com, michalechner92@googlemail.com,
soheil@google.com, paulmck@kernel.org, jannh@google.com,
liam.howlett@oracle.com, shakeelb@google.com, luto@kernel.org,
gthelen@google.com, ldufour@linux.ibm.com,
Suren Baghdasaryan <surenb@google.com>,
vbabka@suse.cz, posk@google.com, lstoakes@gmail.com,
peterjung1337@gmail.com, linuxppc-dev@lists.ozlabs.org,
kent.overstreet@lin ux.dev, linux-kernel@vger.kernel.org,
hannes@cmpxchg.org, tatashin@google.com,
mgorman@techsingularity.net, rppt@kernel.org
Subject: [PATCH 1/1] mm/nommu: remove unnecessary VMA locking
Date: Wed, 1 Mar 2023 11:04:57 -0800 [thread overview]
Message-ID: <20230301190457.1498985-1-surenb@google.com> (raw)
Since CONFIG_PER_VMA_LOCK depends on CONFIG_MMU, the changes in nommu
are not needed. Remove them.
Fixes: bad94decd6a4 ("mm: write-lock VMAs before removing them from VMA tree")
Reported-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Link: https://lore.kernel.org/all/Y%2F8CJQGNuMUTdLwP@localhost/
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
Fix cleanly applies over mm-unstable, SHA in "Fixes" is from that tree.
mm/nommu.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index 2ab162d773e2..57ba243c6a37 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -588,7 +588,6 @@ static int delete_vma_from_mm(struct vm_area_struct *vma)
current->pid);
return -ENOMEM;
}
- vma_start_write(vma);
cleanup_vma_from_mm(vma);
/* remove from the MM's tree and list */
@@ -1520,10 +1519,6 @@ void exit_mmap(struct mm_struct *mm)
*/
mmap_write_lock(mm);
for_each_vma(vmi, vma) {
- /*
- * No need to lock VMA because this is the only mm user and no
- * page fault handled can race with it.
- */
cleanup_vma_from_mm(vma);
delete_vma(mm, vma);
cond_resched();
--
2.40.0.rc0.216.gc4246ad0f0-goog
next reply other threads:[~2023-03-01 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 19:04 Suren Baghdasaryan [this message]
2023-03-02 9:41 ` [PATCH 1/1] mm/nommu: remove unnecessary VMA locking David Hildenbrand
2023-03-03 1:34 ` Suren Baghdasaryan
2023-03-03 9:05 ` David Hildenbrand
2023-03-03 16:14 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301190457.1498985-1-surenb@google.com \
--to=surenb@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjunroy@google.com \
--cc=axelrasmussen@google.com \
--cc=bigeasy@linutronix.de \
--cc=chriscli@google.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=gthelen@google.com \
--cc=gurua@google.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jglisse@google.com \
--cc=joelaf@google.com \
--cc=kent.overstreet@lin \
--cc=kernel-team@android.com \
--cc=ldufour@linux.ibm.com \
--cc=leewalsh@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=michalechner92@googlemail.com \
--cc=michel@lespinasse.org \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterjung1337@gmail.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=posk@google.com \
--cc=punit.agrawal@bytedance.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=soheil@google.com \
--cc=songliubraving@fb.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).