linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
	Fabio Estevam <festevam@gmail.com>,
	kernel@pengutronix.de
Subject: [PATCH 070/173] ASoC: fsl: fsl_mqs: Convert to platform remove callback returning void
Date: Wed, 15 Mar 2023 16:06:02 +0100	[thread overview]
Message-ID: <20230315150745.67084-71-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de>

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 sound/soc/fsl/fsl_mqs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index 4922e6795b73..3fb3d3e4d09a 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -261,10 +261,9 @@ static int fsl_mqs_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int fsl_mqs_remove(struct platform_device *pdev)
+static void fsl_mqs_remove(struct platform_device *pdev)
 {
 	pm_runtime_disable(&pdev->dev);
-	return 0;
 }
 
 #ifdef CONFIG_PM
@@ -360,7 +359,7 @@ MODULE_DEVICE_TABLE(of, fsl_mqs_dt_ids);
 
 static struct platform_driver fsl_mqs_driver = {
 	.probe		= fsl_mqs_probe,
-	.remove		= fsl_mqs_remove,
+	.remove_new	= fsl_mqs_remove,
 	.driver		= {
 		.name	= "fsl-mqs",
 		.of_match_table = fsl_mqs_dt_ids,
-- 
2.39.2


  parent reply	other threads:[~2023-03-15 15:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 15:04 [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 010/173] ALSA: ppc/powermac: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 064/173] ASoC: fsl: fsl_asrc: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 065/173] ASoC: fsl: fsl_aud2htx: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 066/173] ASoC: fsl: fsl_audmix: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 067/173] ASoC: fsl: fsl_dma: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 068/173] ASoC: fsl: fsl_easrc: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 069/173] ASoC: fsl: fsl_esai: " Uwe Kleine-König
2023-03-15 15:06 ` Uwe Kleine-König [this message]
2023-03-15 15:06 ` [PATCH 071/173] ASoC: fsl: fsl_rpmsg: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 072/173] ASoC: fsl: fsl_sai: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 073/173] ASoC: fsl: fsl_spdif: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 074/173] ASoC: fsl: fsl_ssi: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 075/173] ASoC: fsl: fsl_xcvr: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 076/173] ASoC: fsl: imx-audmux: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 077/173] ASoC: fsl: imx-pcm-rpmsg: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 078/173] ASoC: fsl: imx-sgtl5000: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 081/173] ASoC: fsl: mpc8610_hpcd: " Uwe Kleine-König
2023-03-16  9:32 ` [PATCH 000/173] ALSA/ASoC: " Takashi Iwai
2023-03-21 16:50 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315150745.67084-71-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=shengjiu.wang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).