From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
devicetree@vger.kernel.org, Bagas Sanjaya <bagasdotme@gmail.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Camelia Alexandra Groza <camelia.groza@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-phy@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 13/13] arm64: dts: ls1088ardb: Add serdes descriptions
Date: Fri, 24 Mar 2023 15:17:01 +0200 [thread overview]
Message-ID: <20230324131701.4ucxf65sxfdtqcai@LXL00007.wbi.nxp.com> (raw)
In-Reply-To: <20230321201313.2507539-14-sean.anderson@seco.com>
On Tue, Mar 21, 2023 at 04:13:12PM -0400, Sean Anderson wrote:
> This adds serdes support to the LS1088ARDB. I have tested the QSGMII
> ports as well as the two 10G ports. The SFP slot is now fully supported,
> instead of being modeled as a fixed-link.
>
> Linux hangs around when the serdes is initialized if the si5341 is
> enabled with the in-tree driver, so I have modeled it as a two fixed
> clocks instead. There are a few registers in the QIXIS FPGA which
> control the SFP GPIOs; I have modeled them as discrete GPIO controllers
> for now. I never saw the AQR105 interrupt fire; not sure what was going
> on, but I have removed it to force polling.
So you didn't see the interrupt fire even without these patches?
I just tested this on a LS1088ARDB and it works.
root@localhost:~# cat /proc/interrupts | grep extirq
99: 5 ls-extirq 2 Level 0x0000000008b97000:00
root@localhost:~# ip link set dev endpmac2 up
root@localhost:~# cat /proc/interrupts | grep extirq
99: 6 ls-extirq 2 Level 0x0000000008b97000:00
root@localhost:~# ip link set dev endpmac2 down
root@localhost:~# cat /proc/interrupts | grep extirq
99: 7 ls-extirq 2 Level 0x0000000008b97000:00
Please don't just remove things.
Ioana
next prev parent reply other threads:[~2023-03-24 13:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 20:12 [PATCH v12 00/13] phy: Add support for Lynx 10G SerDes Sean Anderson
2023-03-21 20:13 ` [PATCH v12 01/13] dt-bindings: phy: Add 2500BASE-X and 10GBASE-R Sean Anderson
2023-03-21 20:13 ` [PATCH v12 02/13] dt-bindings: phy: Add Lynx 10G phy binding Sean Anderson
2023-03-21 20:13 ` [PATCH v12 03/13] dt-bindings: Convert gpio-mmio to yaml Sean Anderson
2023-03-21 20:19 ` Sean Anderson
2023-03-21 22:33 ` Rob Herring
2023-03-21 20:13 ` [PATCH v12 04/13] dt-bindings: gpio-mmio: Add compatible for QIXIS Sean Anderson
2023-03-21 20:13 ` [PATCH v12 05/13] dt-bindings: clock: Add ids for Lynx 10g PLLs Sean Anderson
2023-03-21 20:13 ` [PATCH v12 06/13] clk: Add Lynx 10G SerDes PLL driver Sean Anderson
2023-03-21 20:13 ` [PATCH v12 07/13] phy: fsl: Add Lynx 10G SerDes driver Sean Anderson
2023-03-21 20:13 ` [PATCH v12 08/13] phy: lynx10g: Enable by default on Layerscape Sean Anderson
2023-03-21 20:13 ` [PATCH v12 09/13] arm64: dts: ls1046a: Add serdes nodes Sean Anderson
2023-03-21 20:13 ` [PATCH v12 10/13] arm64: dts: ls1046ardb: Add serdes descriptions Sean Anderson
2023-03-21 20:13 ` [PATCH v12 11/13] arm64: dts: ls1088a: Add serdes nodes Sean Anderson
2023-03-21 20:13 ` [PATCH v12 12/13] arm64: dts: ls1088a: Prevent PCSs from probing as phys Sean Anderson
2023-03-21 20:13 ` [PATCH v12 13/13] arm64: dts: ls1088ardb: Add serdes descriptions Sean Anderson
2023-03-24 13:17 ` Ioana Ciornei [this message]
2023-03-27 18:15 ` Sean Anderson
2023-03-27 19:56 ` Sean Anderson
2023-03-28 9:25 ` Ioana Ciornei
2023-03-28 14:40 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324131701.4ucxf65sxfdtqcai@LXL00007.wbi.nxp.com \
--to=ioana.ciornei@nxp.com \
--cc=bagasdotme@gmail.com \
--cc=camelia.groza@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=robh+dt@kernel.org \
--cc=sean.anderson@seco.com \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).