From: Joel Savitz <jsavitz@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Gonzalo Siero <gsierohu@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Benjamin Gray <bgray@linux.ibm.com>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Joel Savitz <jsavitz@redhat.com>
Subject: [PATCH] powerpc: align memory_limit to 16MB in early_parse_mem
Date: Fri, 1 Mar 2024 15:30:23 -0500 [thread overview]
Message-ID: <20240301203023.2197451-1-jsavitz@redhat.com> (raw)
On 64-bit powerpc, usage of a non-16MB-aligned value for the mem= kernel
cmdline parameter results in a system hang at boot.
For example, using 'mem=4198400K' will always reproduce this issue.
This patch fixes the problem by aligning any argument to mem= to 16MB
corresponding with the large page size on powerpc.
Fixes: 2babf5c2ec2f ("[PATCH] powerpc: Unify mem= handling")
Co-developed-by: Gonzalo Siero <gsierohu@redhat.com>
Signed-off-by: Gonzalo Siero <gsierohu@redhat.com>
Signed-off-by: Joel Savitz <jsavitz@redhat.com>
---
arch/powerpc/kernel/prom.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index 0b5878c3125b..8cd3e2445d8a 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -82,8 +82,12 @@ static int __init early_parse_mem(char *p)
{
if (!p)
return 1;
-
+#ifdef CONFIG_PPC64
+ /* Align to 16 MB == size of ppc64 large page */
+ memory_limit = ALIGN(memparse(p, &p), 0x1000000);
+#else
memory_limit = PAGE_ALIGN(memparse(p, &p));
+#endif
DBG("memory limit = 0x%llx\n", memory_limit);
return 0;
--
2.43.0
next reply other threads:[~2024-03-01 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 20:30 Joel Savitz [this message]
2024-03-01 23:23 ` [PATCH] powerpc: align memory_limit to 16MB in early_parse_mem Michael Ellerman
2024-03-02 23:59 ` Joel Savitz
2024-03-08 9:30 ` Michael Ellerman
2024-03-04 6:58 ` Aneesh Kumar K.V
2024-03-08 10:18 ` Aneesh Kumar K.V
2024-03-26 4:45 ` Joel Savitz
2024-04-01 14:17 ` Joel Savitz
2024-04-10 15:22 ` Joel Savitz
2024-04-10 15:31 ` Christophe Leroy
2024-04-10 16:52 ` Joel Savitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301203023.2197451-1-jsavitz@redhat.com \
--to=jsavitz@redhat.com \
--cc=aneesh.kumar@kernel.org \
--cc=bgray@linux.ibm.com \
--cc=gsierohu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).