From: Simon Horman <horms@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Brendan Higgins" <brendan.higgins@linux.dev>,
linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org,
"David Airlie" <airlied@gmail.com>,
"Arthur Grillo" <arthurgrillo@riseup.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
"Daniel Diaz" <daniel.diaz@linaro.org>,
linux-sh@vger.kernel.org,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Linux Kernel Functional Testing" <lkft@linaro.org>,
"Kees Cook" <keescook@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"David Gow" <davidgow@google.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com,
linux-parisc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces
Date: Wed, 27 Mar 2024 14:44:31 +0000 [thread overview]
Message-ID: <20240327144431.GL403975@kernel.org> (raw)
In-Reply-To: <20240325175248.1499046-13-linux@roeck-us.net>
On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote:
> Add name of functions triggering warning backtraces to the __bug_table
> object section to enable support for suppressing WARNING backtraces.
>
> To limit image size impact, the pointer to the function name is only added
> to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and
> CONFIG_DEBUG_BUGVERBOSE are enabled. Otherwise, the __func__ assembly
> parameter is replaced with a (dummy) NULL parameter to avoid an image size
> increase due to unused __func__ entries (this is necessary because __func__
> is not a define but a virtual variable).
>
> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Acked-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> - Rebased to v6.9-rc1
> - Added Tested-by:, Acked-by:, and Reviewed-by: tags
> - Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
>
> arch/sh/include/asm/bug.h | 26 ++++++++++++++++++++++----
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/arch/sh/include/asm/bug.h b/arch/sh/include/asm/bug.h
> index 05a485c4fabc..470ce6567d20 100644
> --- a/arch/sh/include/asm/bug.h
> +++ b/arch/sh/include/asm/bug.h
> @@ -24,21 +24,36 @@
> * The offending file and line are encoded in the __bug_table section.
> */
> #ifdef CONFIG_DEBUG_BUGVERBOSE
> +
> +#ifdef CONFIG_KUNIT_SUPPRESS_BACKTRACE
> +# define HAVE_BUG_FUNCTION
> +# define __BUG_FUNC_PTR "\t.long %O2\n"
> +#else
> +# define __BUG_FUNC_PTR
> +#endif /* CONFIG_KUNIT_SUPPRESS_BACKTRACE */
> +
Hi Guenter,
a minor nit from my side: this change results in a Kernel doc warning.
.../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead
Perhaps either the new code should be placed above the Kernel doc,
or scripts/kernel-doc should be enhanced?
> #define _EMIT_BUG_ENTRY \
> "\t.pushsection __bug_table,\"aw\"\n" \
> "2:\t.long 1b, %O1\n" \
> - "\t.short %O2, %O3\n" \
> - "\t.org 2b+%O4\n" \
> + __BUG_FUNC_PTR \
> + "\t.short %O3, %O4\n" \
> + "\t.org 2b+%O5\n" \
> "\t.popsection\n"
> #else
> #define _EMIT_BUG_ENTRY \
> "\t.pushsection __bug_table,\"aw\"\n" \
> "2:\t.long 1b\n" \
> - "\t.short %O3\n" \
> - "\t.org 2b+%O4\n" \
> + "\t.short %O4\n" \
> + "\t.org 2b+%O5\n" \
> "\t.popsection\n"
> #endif
>
> +#ifdef HAVE_BUG_FUNCTION
> +# define __BUG_FUNC __func__
> +#else
> +# define __BUG_FUNC NULL
> +#endif
> +
> #define BUG() \
> do { \
> __asm__ __volatile__ ( \
...
next prev parent reply other threads:[~2024-03-27 14:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:52 [PATCH v2 00/14] Add support for suppressing warning backtraces Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 01/14] bug/kunit: Core " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 02/14] kunit: bug: Count suppressed " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 03/14] kunit: Add test cases for backtrace warning suppression Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 04/14] kunit: Add documentation for warning backtrace suppression API Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 05/14] drm: Suppress intentional warning backtraces in scaling unit tests Guenter Roeck
2024-03-25 19:05 ` Maíra Canal
2024-03-25 19:24 ` Guenter Roeck
2024-03-26 1:09 ` Maíra Canal
2024-03-26 5:02 ` Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 06/14] net: kunit: Suppress lock warning noise at end of dev_addr_lists tests Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 07/14] x86: Add support for suppressing warning backtraces Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 08/14] arm64: " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 09/14] loongarch: " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 10/14] parisc: " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 11/14] s390: " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 12/14] sh: " Guenter Roeck
2024-03-27 14:44 ` Simon Horman [this message]
2024-03-27 15:10 ` Guenter Roeck
2024-03-27 19:39 ` Simon Horman
2024-03-29 15:40 ` Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 13/14] riscv: " Guenter Roeck
2024-03-25 17:52 ` [PATCH v2 14/14] powerpc: " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327144431.GL403975@kernel.org \
--to=horms@kernel.org \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arthurgrillo@riseup.net \
--cc=brendan.higgins@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=daniel.diaz@linaro.org \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft@linaro.org \
--cc=loongarch@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).