From: Abhinav Jain <jain.abhinav177@gmail.com>
To: mahesh@linux.ibm.com, oohall@gmail.com, bhelgaas@google.com,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: javier.carrasco.cruz@gmail.com,
Abhinav Jain <jain.abhinav177@gmail.com>,
skhan@linuxfoundation.org
Subject: [PATCH] PCI/AER: Print error message as per the TODO
Date: Mon, 15 Apr 2024 16:10:55 +0000 [thread overview]
Message-ID: <20240415161055.8316-1-jain.abhinav177@gmail.com> (raw)
Add a pr_err() to print the add device error in find_device_iter()
Signed-off-by: Abhinav Jain <jain.abhinav177@gmail.com>
---
drivers/pci/pcie/aer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index ac6293c24976..0e1ad2998116 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void *data)
/* List this device */
if (add_error_device(e_info, dev)) {
/* We cannot handle more... Stop iteration */
- /* TODO: Should print error message here? */
+ pr_err("find_device_iter: Cannot handle more devices.
+ Stopping iteration");
return 1;
}
--
2.34.1
next reply other threads:[~2024-04-15 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 16:10 Abhinav Jain [this message]
2024-04-15 16:19 ` [PATCH] PCI/AER: Print error message as per the TODO Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415161055.8316-1-jain.abhinav177@gmail.com \
--to=jain.abhinav177@gmail.com \
--cc=bhelgaas@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).