From: Alistair Popple <alistair@popple.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Reza Arbab <arbab@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH kernel] powerpc/powernv/npu: Remove unused headers and a macro.
Date: Thu, 29 Nov 2018 13:26:14 +1100 [thread overview]
Message-ID: <2156566.iAVFplbFpW@townsend> (raw)
In-Reply-To: <f3bdbac9-b36f-afca-614a-0ff6fe199e7c@ozlabs.ru>
Thanks! Looks like a reasonable cleanup. Assuming it compiles I can't see any
reason not to add:
Acked-by: Alistair Popple <alistair@popple.id.au>
On Thursday, 29 November 2018 1:11:34 PM AEDT Alexey Kardashevskiy wrote:
> Ping?
>
> On 28/09/2018 16:48, Alexey Kardashevskiy wrote:
> > The macro and few headers are not used so remove them.
> >
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> > ---
> >
> > arch/powerpc/platforms/powernv/npu-dma.c | 14 --------------
> > 1 file changed, 14 deletions(-)
> >
> > diff --git a/arch/powerpc/platforms/powernv/npu-dma.c
> > b/arch/powerpc/platforms/powernv/npu-dma.c index 8006c54..3a5c4ed 100644
> > --- a/arch/powerpc/platforms/powernv/npu-dma.c
> > +++ b/arch/powerpc/platforms/powernv/npu-dma.c
> > @@ -9,32 +9,18 @@
> >
> > * License as published by the Free Software Foundation.
> > */
> >
> > -#include <linux/slab.h>
> >
> > #include <linux/mmu_notifier.h>
> > #include <linux/mmu_context.h>
> > #include <linux/of.h>
> >
> > -#include <linux/export.h>
> >
> > #include <linux/pci.h>
> > #include <linux/memblock.h>
> >
> > -#include <linux/iommu.h>
> > -#include <linux/debugfs.h>
> >
> > #include <asm/debugfs.h>
> >
> > -#include <asm/tlb.h>
> >
> > #include <asm/powernv.h>
> >
> > -#include <asm/reg.h>
> > -#include <asm/opal.h>
> > -#include <asm/io.h>
> > -#include <asm/iommu.h>
> > -#include <asm/pnv-pci.h>
> > -#include <asm/msi_bitmap.h>
> >
> > #include <asm/opal.h>
> >
> > -#include "powernv.h"
> >
> > #include "pci.h"
> >
> > -#define npu_to_phb(x) container_of(x, struct pnv_phb, npu)
> > -
> >
> > /*
> >
> > * spinlock to protect initialisation of an npu_context for a particular
> > * mm_struct.
next prev parent reply other threads:[~2018-11-29 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 6:48 [PATCH kernel] powerpc/powernv/npu: Remove unused headers and a macro Alexey Kardashevskiy
2018-11-29 2:11 ` Alexey Kardashevskiy
2018-11-29 2:26 ` Alistair Popple [this message]
2018-12-23 13:28 ` [kernel] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2156566.iAVFplbFpW@townsend \
--to=alistair@popple.id.au \
--cc=aik@ozlabs.ru \
--cc=arbab@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).