From: Geoff Levand <geoff@infradead.org>
To: Mathieu Malaterre <malat@debian.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Move static keyword at beginning of declaration
Date: Sat, 2 Feb 2019 09:56:00 -0800 [thread overview]
Message-ID: <2205d42d-1dc9-7d80-6c85-4162763ee9e9@infradead.org> (raw)
In-Reply-To: <20190202130535.2761-1-malat@debian.org>
On 2/2/19 5:05 AM, Mathieu Malaterre wrote:
> Move the static keyword around to remove the following warnings (W=1):
>
> arch/powerpc/platforms/ps3/os-area.c:212:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> arch/powerpc/platforms/ps3/system-bus.c:45:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> -struct saved_params {
> +static struct saved_params {
> unsigned int valid;
> s64 rtc_diff;
> unsigned int av_multi_out;
> -} static saved_params;
> +} saved_params;
Seems fine.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2019-02-02 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 13:05 [PATCH] Move static keyword at beginning of declaration Mathieu Malaterre
2019-02-02 17:56 ` Geoff Levand [this message]
2019-02-08 13:02 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2205d42d-1dc9-7d80-6c85-4162763ee9e9@infradead.org \
--to=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).