From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48358C4332E for ; Sat, 21 Mar 2020 10:29:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBB6B2072C for ; Sat, 21 Mar 2020 10:29:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="tUHJdpw7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBB6B2072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48kxjF0Yy9zDsMM for ; Sat, 21 Mar 2020 21:29:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.a=rsa-sha256 header.s=mail header.b=tUHJdpw7; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48kxgP1GgCzF0PZ for ; Sat, 21 Mar 2020 21:28:16 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48kxgF72twz9v2D7; Sat, 21 Mar 2020 11:28:09 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=tUHJdpw7; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id KSOyuxWAekaG; Sat, 21 Mar 2020 11:28:09 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48kxgF5gGLz9v2D1; Sat, 21 Mar 2020 11:28:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1584786489; bh=/IOWVhiwPMCQRgzudKKMRxz9b+oGxzhOIS1ciBnze10=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tUHJdpw7KMK/9HR8wuUSQZcnGU8xLse/+rfWQcCt7vpyVUqxLj2CGKahX15nix2Fu Wbetx+yW8kfHEc8qe4fOZm5rS/Mjkdfwf4d5Ju6qjWTJriSpcZDZl791KdwGttaxBO SlkJhPmFiV7k3vuNlWGKcKS1K4+hzLIpui7Hdz0Y= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E86CA8B774; Sat, 21 Mar 2020 11:28:10 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id mwGAEoGi0FQi; Sat, 21 Mar 2020 11:28:10 +0100 (CET) Received: from pc16570vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3368E8B752; Sat, 21 Mar 2020 11:28:10 +0100 (CET) Subject: Re: [PATCH v5 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions. To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , mikey@neuling.org References:

<87imizdbaz.fsf@mpe.ellerman.id.au> From: Christophe Leroy Message-ID: <25a7f050-f241-6035-e778-16b1ca9928f3@c-s.fr> Date: Sat, 21 Mar 2020 10:27:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87imizdbaz.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 03/20/2020 02:12 AM, Michael Ellerman wrote: > Christophe Leroy writes: >> Move ADV_DEBUG_REGS functions out of ptrace.c, into >> ptrace-adv.c and ptrace-noadv.c >> >> Signed-off-by: Christophe Leroy >> --- >> v4: Leave hw_breakpoint.h for ptrace.c >> --- >> arch/powerpc/kernel/ptrace/Makefile | 4 + >> arch/powerpc/kernel/ptrace/ptrace-adv.c | 468 ++++++++++++++++ >> arch/powerpc/kernel/ptrace/ptrace-decl.h | 5 + >> arch/powerpc/kernel/ptrace/ptrace-noadv.c | 236 ++++++++ >> arch/powerpc/kernel/ptrace/ptrace.c | 650 ---------------------- >> 5 files changed, 713 insertions(+), 650 deletions(-) >> create mode 100644 arch/powerpc/kernel/ptrace/ptrace-adv.c >> create mode 100644 arch/powerpc/kernel/ptrace/ptrace-noadv.c > > This is somehow breaking the ptrace-hwbreak selftest on Power8: > > test: ptrace-hwbreak > tags: git_version:v5.6-rc6-892-g7a285a6067d6 > PTRACE_SET_DEBUGREG, WO, len: 1: Ok > PTRACE_SET_DEBUGREG, WO, len: 2: Ok > PTRACE_SET_DEBUGREG, WO, len: 4: Ok > PTRACE_SET_DEBUGREG, WO, len: 8: Ok > PTRACE_SET_DEBUGREG, RO, len: 1: Ok > PTRACE_SET_DEBUGREG, RO, len: 2: Ok > PTRACE_SET_DEBUGREG, RO, len: 4: Ok > PTRACE_SET_DEBUGREG, RO, len: 8: Ok > PTRACE_SET_DEBUGREG, RW, len: 1: Ok > PTRACE_SET_DEBUGREG, RW, len: 2: Ok > PTRACE_SET_DEBUGREG, RW, len: 4: Ok > PTRACE_SET_DEBUGREG, RW, len: 8: Ok > PPC_PTRACE_SETHWDEBUG, MODE_EXACT, WO, len: 1: Ok > PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RO, len: 1: Ok > PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RW, len: 1: Ok > PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, WO, len: 6: Ok > PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RO, len: 6: Ok > PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RW, len: 6: Ok > PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW UNALIGNED, WO, len: 6: Ok > PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW UNALIGNED, RO, len: 6: Fail > failure: ptrace-hwbreak > > I haven't had time to work out why yet. > A (big) part of commit c3f68b0478e7 ("powerpc/watchpoint: Fix ptrace code that muck around with address/len") was lost during rebase. I'll send a fix, up to you to squash it in or commit it as is. Christophe