From: maddy <maddy@linux.ibm.com>
To: Kajol Jain <kjain@linux.ibm.com>,
acme@kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: ravi.bangoria@linux.ibm.com, maddy@linux.vnet.ibm.com,
jmario@redhat.com, mpetlan@redhat.com, peterz@infradead.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
alexander.shishkin@linux.intel.com,
linux-perf-users@vger.kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com, anju@linux.vnet.ibm.com,
jolsa@kernel.org, namhyung@kernel.org, mingo@kernel.org,
kan.liang@linux.intel.com
Subject: Re: [PATCH 8/8] perf/tools/pmu-events/powerpc: Add hv_24x7 socket/chip level metric events
Date: Thu, 20 Feb 2020 15:23:41 +0530 [thread overview]
Message-ID: <276f2495-c838-cae4-d654-065e43b0323a@linux.ibm.com> (raw)
In-Reply-To: <20200214110335.31483-9-kjain@linux.ibm.com>
On 2/14/20 4:33 PM, Kajol Jain wrote:
> The hv_24×7 feature in IBM® POWER9™ processor-based servers provide the
> facility to continuously collect large numbers of hardware performance
> metrics efficiently and accurately.
> This patch adds hv_24x7 json metric file for different Socket/chip
> resources.
>
> Result:
>
> power9 platform:
>
> command:# ./perf stat --metric-only -M Memory_RD_BW_Chip -C 0
> -I 1000 sleep 1
>
> time MB Memory_RD_BW_Chip_0 MB Memory_RD_BW_Chip_1 MB
> 1.000192635 0.4 0.0
> 1.001695883 0.0 0.0
>
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> ---
> .../arch/powerpc/power9/hv_24x7_metrics.json | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/hv_24x7_metrics.json
>
> diff --git a/tools/perf/pmu-events/arch/powerpc/power9/hv_24x7_metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/hv_24x7_metrics.json
> new file mode 100644
> index 000000000000..ac38f5540ac6
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/powerpc/power9/hv_24x7_metrics.json
Better to have it as nest_metrics.json instead. Rest looks fine
Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>
> @@ -0,0 +1,19 @@
> +[
> + {
> + "MetricExpr": "(hv_24x7@PM_MCS01_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS01_128B_RD_DISP_PORT23\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_RD_DISP_PORT23\\,chip\\=?@)",
> + "MetricName": "Memory_RD_BW_Chip",
> + "MetricGroup": "Memory_BW",
> + "ScaleUnit": "1.6e-2MB"
> + },
> + {
> + "MetricExpr": "(hv_24x7@PM_MCS01_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS01_128B_WR_DISP_PORT23\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@PM_MCS23_128B_WR_DISP_PORT23\\,chip\\=?@ )",
> + "MetricName": "Memory_WR_BW_Chip",
> + "MetricGroup": "Memory_BW",
> + "ScaleUnit": "1.6e-2MB"
> + },
> + {
> + "MetricExpr": "(hv_24x7@PM_PB_CYC\\,chip\\=?@ )",
> + "MetricName": "PowerBUS_Frequency",
> + "ScaleUnit": "2.5e-7GHz"
> + }
> +]
prev parent reply other threads:[~2020-02-20 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:03 [PATCH 0/8] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events Kajol Jain
2020-02-14 11:03 ` [PATCH 1/8] powerpc/perf/hv-24x7: Fix inconsistent output values incase multiple hv-24x7 events run Kajol Jain
2020-02-14 11:03 ` [PATCH 2/8] powerpc/hv-24x7: Add rtas call in hv-24x7 driver to get processor details Kajol Jain
2020-02-14 11:03 ` [PATCH 3/8] powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show " Kajol Jain
2020-02-14 11:03 ` [PATCH 4/8] Documentation/ABI: Add ABI documentation for chips and sockets Kajol Jain
2020-02-14 11:03 ` [PATCH 5/8] powerpc/hv-24x7: Update post_mobility_fixup() to handle migration Kajol Jain
2020-02-14 11:03 ` [PATCH 6/8] perf/tools: Enhance JSON/metric infrastructure to handle "?" Kajol Jain
2020-02-14 11:03 ` [PATCH 7/8] tools/perf: Enable Hz/hz prinitg for --metric-only option Kajol Jain
2020-02-14 11:03 ` [PATCH 8/8] perf/tools/pmu-events/powerpc: Add hv_24x7 socket/chip level metric events Kajol Jain
2020-02-20 9:53 ` maddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276f2495-c838-cae4-d654-065e43b0323a@linux.ibm.com \
--to=maddy@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).