From: Sathvika Vasireddy <sv@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "aik@ozlabs.ru" <aik@ozlabs.ru>,
"chenzhongjin@huawei.com" <chenzhongjin@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mingo@redhat.com" <mingo@redhat.com>,
Sathvika Vasireddy <sv@linux.ibm.com>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"naveen.n.rao@linux.vnet.ibm.com"
<naveen.n.rao@linux.vnet.ibm.com>,
"mbenes@suse.cz" <mbenes@suse.cz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v5 02/16] powerpc: Override __ALIGN and __ALIGN_STR macros
Date: Mon, 14 Nov 2022 09:18:48 +0530 [thread overview]
Message-ID: <278ef11d-f85d-512e-e7e8-0685653a2e45@linux.ibm.com> (raw)
In-Reply-To: <Y2OAdHBIGXVnN5Ud@hirez.programming.kicks-ass.net>
Hi Peter,
On 03/11/22 14:18, Peter Zijlstra wrote:
> On Wed, Nov 02, 2022 at 12:35:07PM +0000, Christophe Leroy wrote:
>>
>> Le 28/10/2022 à 16:33, Sathvika Vasireddy a écrit :
>>> In a subsequent patch, we would want to annotate powerpc assembly functions
>>> with SYM_FUNC_START_LOCAL macro. This macro depends on __ALIGN macro.
>>>
>>> The default expansion of __ALIGN macro is:
>>> #define __ALIGN .align 4,0x90
>>>
>>> So, override __ALIGN and __ALIGN_STR macros to use the same alignment as
>>> that of the existing _GLOBAL macro. Also, do not pad with 0x90, because
>>> repeated 0x90s are not a nop or trap on powerpc.
>> By the way, do we know what the instruction 0x90909090 is on powerpc ?
>> Is that something valid or not ?
> Please also look at the version that's in tip/x86/core (and next). This
> stuff should be gone now.
>
> include/linux/linkage.h now reads like:
>
> #ifndef __ALIGN
> #define __ALIGN .balign CONFIG_FUNCTION_ALIGNMENT
> #define __ALIGN_STR __stringify(__ALIGN)
> #endif
Since the above mentioned changes are not a part of powerpc/merge branch
yet, I am retaining this patch for this merge cycle and will post a
cleanup patch (to move to using FUNCTION_ALIGNMENT_4B) after the next -rc1.
Thanks,
Sathvika
next prev parent reply other threads:[~2022-11-14 3:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 14:33 [PATCH v5 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 01/16] powerpc: Fix __WARN_FLAGS() for use with Objtool Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 02/16] powerpc: Override __ALIGN and __ALIGN_STR macros Sathvika Vasireddy
2022-11-02 12:35 ` Christophe Leroy
2022-11-03 0:01 ` Michael Ellerman
2022-11-03 8:48 ` Peter Zijlstra
2022-11-14 3:48 ` Sathvika Vasireddy [this message]
2022-10-28 14:33 ` [PATCH v5 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 04/16] powerpc: Curb objtool unannotated intra-function warnings Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy
2022-11-02 12:44 ` Christophe Leroy
2022-10-28 14:33 ` [PATCH v5 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 10/16] objtool: Use target file class size " Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-10-28 14:33 ` [PATCH v5 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-11-02 12:44 ` [PATCH v5 00/16] objtool: Enable and implement --mcount option on powerpc Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=278ef11d-f85d-512e-e7e8-0685653a2e45@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=chenzhongjin@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).