From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CEAC282C0 for ; Wed, 23 Jan 2019 14:57:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 806D720870 for ; Wed, 23 Jan 2019 14:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="F3qPcDBg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 806D720870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43l7gb3gTdzDqLS for ; Thu, 24 Jan 2019 01:57:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="F3qPcDBg"; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43l7dm6XFLzDqGk for ; Thu, 24 Jan 2019 01:56:12 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 43l7dd4Mcjz9tyTN; Wed, 23 Jan 2019 15:56:05 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=F3qPcDBg; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id KCT9hiWv9axF; Wed, 23 Jan 2019 15:56:05 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 43l7dd396Dz9tyTL; Wed, 23 Jan 2019 15:56:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1548255365; bh=sSpBcnR1qxezOo1ri8qRsSrq7fLG0SxqCxAbgIGwrBs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=F3qPcDBgEgn4kltWSxnGy+D5nem5aJmbvstdrm+IFkantZ2X4qhOh1w+Tjsl9Phnp dqQ3yp4o3Hqd4bYtkq6vBCB1xdlZ9zLtR+VExiQ9dxiZ/A/mYYYCbGUddKr+4aACjC VaaiCO6C9PKG98Gte4OahF0oeZkm1fYvHxq3GTIA= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E2FC08B820; Wed, 23 Jan 2019 15:56:06 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id vMi-tTw7U0b6; Wed, 23 Jan 2019 15:56:06 +0100 (CET) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5BCCB8B81E; Wed, 23 Jan 2019 15:56:06 +0100 (CET) Subject: Re: [PATCH] tools/testing/selftests/powerpc: Add Anton's null_syscall benchmark to the selftests To: Rui Teng , Anton Blanchard References: <20160927141016.6027-1-rui.teng@linux.vnet.ibm.com> From: Christophe Leroy Message-ID: <2b98b303-d0d4-9f1d-9c47-fde0afb1306c@c-s.fr> Date: Wed, 23 Jan 2019 15:56:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20160927141016.6027-1-rui.teng@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Neuling , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Cyril Bur Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 27/09/2016 à 16:10, Rui Teng a écrit : > From: Anton Blanchard > > Pull in a version of Anton's null_syscall benchmark: > http://ozlabs.org/~anton/junkcode/null_syscall.c > Into tools/testing/selftests/powerpc/benchmarks. > > Suggested-by: Michael Ellerman > Signed-off-by: Anton Blanchard > Signed-off-by: Rui Teng > --- > .../testing/selftests/powerpc/benchmarks/Makefile | 2 +- > .../selftests/powerpc/benchmarks/null_syscall.c | 157 +++++++++++++++++++++ > 2 files changed, 158 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/powerpc/benchmarks/null_syscall.c > [...] > + > +static void do_null_syscall(unsigned long nr) > +{ > + unsigned long i; > + > + for (i = 0; i < nr; i++) > + getppid(); > +} > + Looks like getppid() performs a rcu_read_lock(). Is that what we want ? Shouldn't we use getpid() instead for a lighter syscall ? Christophe