linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyj_lk@163.com>
To: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Cc: John Allen <jallen@linux.vnet.ibm.com>,
	netdev@vger.kernel.org,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2] ibmvnic: fix to use list_for_each_safe() when delete items
Date: Wed, 22 Jun 2016 10:51:46 +0800	[thread overview]
Message-ID: <2db3a1f8-cafd-8fde-6223-2b2e3787d615@163.com> (raw)
In-Reply-To: <576964CF.3040804@linux.vnet.ibm.com>

Since we will remove items off the list using list_del() we need
to use a safe version of the list_for_each() macro aptly named
list_for_each_safe().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
  drivers/net/ethernet/ibm/ibmvnic.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 864cb21..ecdb685 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2121,7 +2121,7 @@ static void handle_error_info_rsp(union ibmvnic_crq *crq,
  				  struct ibmvnic_adapter *adapter)
  {
  	struct device *dev = &adapter->vdev->dev;
-	struct ibmvnic_error_buff *error_buff;
+	struct ibmvnic_error_buff *error_buff, *tmp;
  	unsigned long flags;
  	bool found = false;
  	int i;
@@ -2133,7 +2133,7 @@ static void handle_error_info_rsp(union ibmvnic_crq *crq,
  	}
  
  	spin_lock_irqsave(&adapter->error_list_lock, flags);
-	list_for_each_entry(error_buff, &adapter->errors, list)
+	list_for_each_entry_safe(error_buff, tmp, &adapter->errors, list)
  		if (error_buff->error_id == crq->request_error_rsp.error_id) {
  			found = true;
  			list_del(&error_buff->list);
@@ -3141,14 +3141,14 @@ static void handle_request_ras_comp_num_rsp(union ibmvnic_crq *crq,
  
  static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter)
  {
-	struct ibmvnic_inflight_cmd *inflight_cmd;
+	struct ibmvnic_inflight_cmd *inflight_cmd, *tmp1;
  	struct device *dev = &adapter->vdev->dev;
-	struct ibmvnic_error_buff *error_buff;
+	struct ibmvnic_error_buff *error_buff, *tmp2;
  	unsigned long flags;
  	unsigned long flags2;
  
  	spin_lock_irqsave(&adapter->inflight_lock, flags);
-	list_for_each_entry(inflight_cmd, &adapter->inflight, list) {
+	list_for_each_entry_safe(inflight_cmd, tmp1, &adapter->inflight, list) {
  		switch (inflight_cmd->crq.generic.cmd) {
  		case LOGIN:
  			dma_unmap_single(dev, adapter->login_buf_token,
@@ -3165,8 +3165,8 @@ static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter)
  			break;
  		case REQUEST_ERROR_INFO:
  			spin_lock_irqsave(&adapter->error_list_lock, flags2);
-			list_for_each_entry(error_buff, &adapter->errors,
-					    list) {
+			list_for_each_entry_safe(error_buff, tmp2,
+						 &adapter->errors, list) {
  				dma_unmap_single(dev, error_buff->dma,
  						 error_buff->len,
  						 DMA_FROM_DEVICE);

  parent reply	other threads:[~2016-06-22  3:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-18  2:53 [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items weiyj_lk
2016-06-20 15:50 ` Thomas Falcon
2016-06-21 16:01   ` Thomas Falcon
2016-06-22  2:23     ` Wei Yongjun
2016-06-22  2:51     ` Wei Yongjun [this message]
2016-06-25 16:02       ` [PATCH v2] " David Miller
2016-06-27 12:48         ` weiyj_lk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2db3a1f8-cafd-8fde-6223-2b2e3787d615@163.com \
    --to=weiyj_lk@163.com \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=tlfalcon@linux.vnet.ibm.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).