From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest
Date: Fri, 8 Feb 2019 14:51:43 +0000 [thread overview]
Message-ID: <2ed8efb9-5cd4-31bf-6c7b-501b9d1925e6@ilande.co.uk> (raw)
In-Reply-To: <41b02fb0-cdc6-6de0-d8fc-44d3d0a8ad70@c-s.fr>
On 08/02/2019 14:45, Christophe Leroy wrote:
> Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit :
>> Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up"
>
> Expected format for the above is:
>
> Commit 123456789abc ("text")
Hi Christophe,
Apologies - I'm fairly new at submitting kernel patches, but I can re-send it in the
correct format later if required.
>> unexpectedly removed the MSR_FE0 and MSR_FE1 bits from the bitmask used to
>> update the MSR of the previous thread in __giveup_fpu() causing a KVM-PR MacOS
>> guest to lockup and panic the kernel.
>>
>> Reinstate these bits to the MSR bitmask to enable MacOS guests to run under
>> 32-bit KVM-PR once again without issue.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
> Should include a Fixes: and a Cc to stable ?
>
> Fixes: 8792468da5e1 ("powerpc: Add the ability to save FPU without giving it up")
> Cc: stable@vger.kernel.org
Indeed, but there are still some questions to be asked here:
1) Why were these bits removed from the original bitmask in the first place without
it being documented in the commit message?
2) Is this the right fix? I'm told that MacOS guests already run without this patch
on a G5 under 64-bit KVM-PR which may suggest that this is a workaround for another
bug elsewhere in the 32-bit powerpc code.
If you think that these points don't matter, then I'm happy to resubmit the patch
as-is based upon your comments above.
ATB,
Mark.
next prev parent reply other threads:[~2019-02-08 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 14:33 [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest Mark Cave-Ayland
2019-02-08 14:45 ` Christophe Leroy
2019-02-08 14:51 ` Mark Cave-Ayland [this message]
2019-02-11 0:30 ` Benjamin Herrenschmidt
2019-02-11 21:39 ` Mark Cave-Ayland
2019-02-19 4:55 ` Michael Ellerman
2019-02-19 8:15 ` Mark Cave-Ayland
2019-02-19 4:20 ` Michael Ellerman
2019-02-19 7:55 ` Mark Cave-Ayland
2019-02-20 12:41 ` Michael Ellerman
2019-02-22 9:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed8efb9-5cd4-31bf-6c7b-501b9d1925e6@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).