From: Pratik Sampat <psampat@linux.ibm.com>
To: Ram Pai <linuxram@us.ibm.com>
Cc: ego@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, pratik.sampat@in.ibm.com
Subject: Re: [RFC 0/3] Integrate Support for self-save and determine
Date: Mon, 6 Jan 2020 15:15:30 +0530 [thread overview]
Message-ID: <31b49402-8af9-fcd7-0c43-d8dd15ce78d7@linux.ibm.com> (raw)
In-Reply-To: <20200103230551.GB5562@oc0525413822.ibm.com>
Thanks for your comments Ram,
>> A list of preferred SPRs are maintained in the kernel which contains two
>> properties:
>> 1. supported_mode: Helps in identifying if it strictly supports self
>> save or restore or both.
> Will be good to capture the information that, 'supported_mode' gets
> initialized using the information from the device tree.
>
>> 2. preferred_mode: Calls out what mode is preferred for each SPR. It
>> could be strictly self save or restore, or it can also
>> determine the preference of mode over the other if both
>> are present by encapsulating the other in bitmask from
>> LSB to MSB.
> and 'preferred_mode' is statically initialized.
>
Sure thing, I'll mention that.
>> Below is a table to show the Scenario::Consequence when the self save and
>> self restore modes are available or disabled in different combinations as
>> perceived from the device tree thus giving complete backwards compatibly
>> regardless of an older firmware running a newer kernel or vise-versa.
>>
>> SR = Self restore; SS = Self save
>>
>> .-----------------------------------.----------------------------------------.
>> | Scenario | Consequence |
>> :-----------------------------------+----------------------------------------:
>> | Legacy Firmware. No SS or SR node | Self restore is called for all |
>> | | supported SPRs |
>> :-----------------------------------+----------------------------------------:
>> | SR: !active SS: !active | Deep stop states disabled |
>> :-----------------------------------+----------------------------------------:
>> | SR: active SS: !active | Self restore is called for all |
>> | | supported SPRs |
>> :-----------------------------------+----------------------------------------:
>> | SR: active SS: active | Goes through the preferences for each |
>> | | SPR and executes of the modes |
>> | | accordingly. Currently, Self restore is|
>> | | called for all the SPRs except PSSCR |
>> | | which is self saved |
>> :-----------------------------------+----------------------------------------:
>> | SR: active(only HID0) SS: active | Self save called for all supported |
>> | | registers expect HID0 (as HID0 cannot |
>> | | be self saved currently) |
> Not clear, how this will be conveyed to the hypervisor? Through the
> device tree or through some other means?
>
This information will be conveyed through the device tree. I'll frame a sentence
that makes this more explicit.
>> :-----------------------------------+----------------------------------------:
>> | SR: !active SS: active | currently will disable deep states as |
>> | | HID0 is needed to be self restored and |
>> | | cannot be self saved |
>> '-----------------------------------'----------------------------------------'
>>
>> Pratik Rajesh Sampat (3):
>> powerpc/powernv: Interface to define support and preference for a SPR
>> powerpc/powernv: Introduce Self save support
>> powerpc/powernv: Parse device tree, population of SPR support
>>
>> arch/powerpc/include/asm/opal-api.h | 3 +-
>> arch/powerpc/include/asm/opal.h | 1 +
>> arch/powerpc/platforms/powernv/idle.c | 431 ++++++++++++++++++---
>> arch/powerpc/platforms/powernv/opal-call.c | 1 +
>> 4 files changed, 379 insertions(+), 57 deletions(-)
>>
>> --
>> 2.21.0
prev parent reply other threads:[~2020-01-06 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 9:32 [RFC 0/3] Integrate Support for self-save and determine Pratik Rajesh Sampat
2019-12-04 9:32 ` [RFC 1/3] powerpc/powernv: Interface to define support and preference for a SPR Pratik Rajesh Sampat
2020-01-03 23:24 ` Ram Pai
2020-01-06 9:46 ` Pratik Sampat
2019-12-04 9:32 ` [RFC 2/3] powerpc/powernv: Introduce Self save support Pratik Rajesh Sampat
2019-12-04 9:32 ` [RFC 3/3] powerpc/powernv: Parse device tree, population of SPR support Pratik Rajesh Sampat
2020-01-03 23:05 ` [RFC 0/3] Integrate Support for self-save and determine Ram Pai
2020-01-06 9:45 ` Pratik Sampat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31b49402-8af9-fcd7-0c43-d8dd15ce78d7@linux.ibm.com \
--to=psampat@linux.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=pratik.sampat@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).