From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097C1C433DF for ; Fri, 16 Oct 2020 03:31:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B571206ED for ; Fri, 16 Oct 2020 03:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Ow45Rwpj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B571206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CCBXW6b3vzDr6w for ; Fri, 16 Oct 2020 14:31:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=aneesh.kumar@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Ow45Rwpj; dkim-atps=neutral Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CCBSL6P7GzDqvl for ; Fri, 16 Oct 2020 14:28:18 +1100 (AEDT) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09G32Xr7104134; Thu, 15 Oct 2020 23:27:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Pfl4Q8UgfBozQRqpOnL7CLwyZw3jIbQSuH7T25QWPHE=; b=Ow45Rwpj9GbCKLc5v3eokJLP5KU4vJbOfORR1Y8avNUXrJouU2KZrAIuJP2wSIxuMM5A um2iRjckka7v6Co3PMCcydvhDKAme7//6VcJjAyTlldbNPaomUocRw1WJTnv9XYOzdPF xTshy7ZsABDs1B9BG/JJa0EtIFBPyK0aIUJEq0qgclphxGBSZYnz//xUOq2zEfH5CW9R dVgmwy/ag8jufdWhR490ftZpMWRs6z32ajNzBPSX8QCOcQotnOe1LvATh0T4GOTAv1UW jYe7S2X6WBpvK0khAv8uZddfwENelSFDcMNV52vYE3Lfcp8XlQ5mhdPisD0eMvMf0AiD 9A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 347386rh02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Oct 2020 23:27:43 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 09G3RgmK157704; Thu, 15 Oct 2020 23:27:42 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 347386rgyg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Oct 2020 23:27:42 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 09G3CufA009117; Fri, 16 Oct 2020 03:27:40 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 3434k7u1cx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Oct 2020 03:27:40 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 09G3RbZ526542500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Oct 2020 03:27:37 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73405AE053; Fri, 16 Oct 2020 03:27:37 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AE056AE045; Fri, 16 Oct 2020 03:27:31 +0000 (GMT) Received: from [9.85.72.211] (unknown [9.85.72.211]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 16 Oct 2020 03:27:31 +0000 (GMT) Subject: Re: [PATCH v6 02/11] mm/gup: Use functions to track lockless pgtbl walks on gup_pgd_range To: =?UTF-8?Q?Michal_Such=c3=a1nek?= , Leonardo Bras References: <20200206030900.147032-1-leonardo@linux.ibm.com> <20200206030900.147032-3-leonardo@linux.ibm.com> <760c238043196e0628c8c0eff48a8e938ef539ba.camel@linux.ibm.com> <20201015144641.GE29778@kitsune.suse.cz> From: "Aneesh Kumar K.V" Message-ID: <3709d0f5-0f92-b003-1d6b-24a61ca2cf1c@linux.ibm.com> Date: Fri, 16 Oct 2020 08:57:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201015144641.GE29778@kitsune.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-16_01:2020-10-16, 2020-10-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1011 mlxscore=0 adultscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=876 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010160017 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Steven Price , Mahesh Salgaonkar , linux-mm@kvack.org, Paul Mackerras , Allison Randal , Andrew Morton , Mike Rapoport , Robin Murphy , Thomas Gleixner , Reza Arbab Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Michal, On 10/15/20 8:16 PM, Michal Suchánek wrote: > Hello, > > On Thu, Feb 06, 2020 at 12:25:18AM -0300, Leonardo Bras wrote: >> On Thu, 2020-02-06 at 00:08 -0300, Leonardo Bras wrote: >>> gup_pgd_range(addr, end, gup_flags, pages, &nr); >>> - local_irq_enable(); >>> + end_lockless_pgtbl_walk(IRQS_ENABLED); >>> ret = nr; >>> } >>> >> >> Just noticed IRQS_ENABLED is not available on other archs than ppc64. >> I will fix this for v7. > > Has threre been v7? > > I cannot find it. > > Thanks > > Michal > https://lore.kernel.org/linuxppc-dev/20200505071729.54912-1-aneesh.kumar@linux.ibm.com This series should help here. -aneesh