From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Sachin Sant <sachinp@linux.vnet.ibm.com>,
linux-kselftest@vger.kernel.org
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, shuahkh@osg.samsung.com
Subject: Re: [RESEND] selftest/powerpc/alignment: Fix false failures for skipped tests
Date: Wed, 8 Mar 2017 18:25:51 +1100 (AEDT) [thread overview]
Message-ID: <3vdQ6l34whz9sN5@ozlabs.org> (raw)
In-Reply-To: <20170226060834.91303.20851.sendpatchset@Sachins-MacBook-Pro.local>
On Sun, 2017-02-26 at 06:08:39 UTC, Sachin Sant wrote:
> Tests under alignment subdirectory are skipped when executed on previous
> generation hardware, but harness still marks them as failed.
>
> test: test_copy_unaligned
> tags: git_version:unknown
> [SKIP] Test skipped on line 26
> skip: test_copy_unaligned
> selftests: copy_unaligned [FAIL]
>
> The MAGIC_SKIP_RETURN_VALUE value assigned to rc variable is retained till
> the program exit which causes the test to be marked as failed.
>
> This patch resets the value before returning to the main() routine.
> With this patch the test o/p is as follows:
>
> test: test_copy_unaligned
> tags: git_version:unknown
> [SKIP] Test skipped on line 26
> skip: test_copy_unaligned
> selftests: copy_unaligned [PASS]
>
> Signed-off-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/a6d8a21596df041f36f4c2ccc260c4
cheers
prev parent reply other threads:[~2017-03-08 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 6:08 [PATCH RESEND] selftest/powerpc/alignment: Fix false failures for skipped tests Sachin Sant
2017-03-08 7:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3vdQ6l34whz9sN5@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).