From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ram Pai <linuxram@us.ibm.com>
Cc: fweimer@redhat.com, dave.hansen@linux.intel.com,
mhocko@kernel.org, Ulrich.Weigand@de.ibm.com,
bauerman@linux.vnet.ibm.com, msuchanek@suse.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [v2] powerpc/pkeys: copy pkey-tracking-information at fork()
Date: Mon, 24 Dec 2018 00:28:06 +1100 (AEDT) [thread overview]
Message-ID: <43N38R5Q9rz9sLw@ozlabs.org> (raw)
In-Reply-To: <20181220200330.GA5385@ram.oc3035372033.ibm.com>
On Thu, 2018-12-20 at 20:03:30 UTC, Ram Pai wrote:
> Pkey tracking information is not copied over to the mm_struct of the
> child during fork(). This can cause the child to erroneously allocate
> keys that were already allocated. Any allocated execute-only key is lost
> aswell.
>
> Add code; called by dup_mmap(), to copy the pkey state from parent to
> child explicitly.
>
> This problem was originally found by Dave Hansen on x86, which turns out
> to be a problem on powerpc aswell.
>
> Reviewed-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> Signed-off-by: Ram Pai <linuxram@us.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/2cd4bd192ee94848695c1c052d8791
cheers
prev parent reply other threads:[~2018-12-23 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 20:43 [PATCH] powerpc/pkeys: copy pkey-tracking-information at fork() Ram Pai
2018-12-04 0:37 ` Thiago Jung Bauermann
2018-12-04 13:00 ` Florian Weimer
2018-12-20 13:19 ` Michael Ellerman
2018-12-20 19:01 ` Ram Pai
2018-12-20 20:03 ` [PATCH v2] " Ram Pai
2018-12-21 0:55 ` Michael Ellerman
2018-12-23 13:28 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43N38R5Q9rz9sLw@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mhocko@kernel.org \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).