From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>,
gregkh@linuxfoundation.org, mikey@neuling.org,
stable@vger.kernel.org
Subject: Re: powerpc/tm: Limit TM code inside PPC_TRANSACTIONAL_MEM
Date: Mon, 14 Jan 2019 21:12:08 +1100 (AEDT) [thread overview]
Message-ID: <43dTm86z85z9sDL@ozlabs.org> (raw)
In-Reply-To: <1547039805-7979-1-git-send-email-leitao@debian.org>
On Wed, 2019-01-09 at 13:16:45 UTC, Breno Leitao wrote:
> Commit e1c3743e1a20 ("powerpc/tm: Set MSR[TS] just prior to recheckpoint")
> moved a code block around and this block uses a 'msr' variable outside of
> the CONFIG_PPC_TRANSACTIONAL_MEM, however the 'msr' variable is declared
> inside a CONFIG_PPC_TRANSACTIONAL_MEM block, causing a possible error when
> CONFIG_PPC_TRANSACTION_MEM is not defined.
>
> error: 'msr' undeclared (first use in this function)
>
> This is not causing a compilation error in the mainline kernel, because
> 'msr' is being used as an argument of MSR_TM_ACTIVE(), which is defined as
> the following when CONFIG_PPC_TRANSACTIONAL_MEM is *not* set:
>
> #define MSR_TM_ACTIVE(x) 0
>
> This patch just fixes this issue avoiding the 'msr' variable usage outside
> the CONFIG_PPC_TRANSACTIONAL_MEM block, avoiding trusting in the
> MSR_TM_ACTIVE() definition.
>
> Cc: stable@vger.kernel.org
> Reported-by: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
> Fixes: e1c3743e1a20 ("powerpc/tm: Set MSR[TS] just prior to recheckpoint")
> Signed-off-by: Breno Leitao <leitao@debian.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/897bc3df8c5aebb54c32d831f917592e
cheers
next prev parent reply other threads:[~2019-01-14 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 13:16 [PATCH] powerpc/tm: Limit TM code inside PPC_TRANSACTIONAL_MEM Breno Leitao
2019-01-14 10:12 ` Michael Ellerman [this message]
2019-01-16 13:35 ` Sasha Levin
2019-01-17 11:49 ` Breno Leitao
2019-01-18 14:51 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43dTm86z85z9sDL@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).