From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ben Hutchings <ben@decadent.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/mm: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations
Date: Fri, 22 Mar 2019 23:21:40 +1100 (AEDT) [thread overview]
Message-ID: <44QjSh4zGhz9sV2@ozlabs.org> (raw)
In-Reply-To: <20190317011756.abjylw3nzfnc6gnh@decadent.org.uk>
On Sun, 2019-03-17 at 01:17:56 UTC, Ben Hutchings wrote:
> MAX_PHYSMEM_BITS only needs to be defined if CONFIG_SPARSEMEM is
> enabled, and that was the case before commit 4ffe713b7587
> ("powerpc/mm: Increase the max addressable memory to 2PB").
>
> On 32-bit systems, where CONFIG_SPARSEMEM is not enabled, we now
> define it as 46. That is larger than the real number of physical
> address bits, and breaks calculations in zsmalloc:
>
> mm/zsmalloc.c:130:49: warning: right shift count is negative [-Wshift-count-negative]
> MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS))
> ^~
> ...
> mm/zsmalloc.c:253:21: error: variably modified 'size_class' at file scope
> struct size_class *size_class[ZS_SIZE_CLASSES];
> ^~~~~~~~~~
>
> Fixes: 4ffe713b7587 ("powerpc/mm: Increase the max addressable memory to 2PB")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/8bc086899816214fbc6047c9c7e15fca
cheers
next prev parent reply other threads:[~2019-03-22 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 1:17 [PATCH] powerpc/mm: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations Ben Hutchings
2019-03-22 12:21 ` Michael Ellerman [this message]
[not found] ` <44QjSh4zGhz9sV2__48832.6491251186$1553257542$gmane$org@ozlabs.org>
2019-03-24 22:18 ` Andreas Schwab
2019-03-24 23:05 ` Ben Hutchings
2019-03-25 0:03 ` Andreas Schwab
2019-03-25 3:54 ` Ben Hutchings
2019-03-25 11:35 ` Michael Ellerman
2019-03-25 12:03 ` Christophe Leroy
2019-03-25 20:12 ` Andreas Schwab
2019-04-02 12:57 ` Aneesh Kumar K.V
2019-03-25 8:54 Rui Salvaterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44QjSh4zGhz9sV2@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=ben@decadent.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).