From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Christoph Hellwig <hch@lst.de>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device
Date: Tue, 14 Apr 2020 16:21:27 +1000 [thread overview]
Message-ID: <44ad32a4-7ce5-4f4d-8237-53356f76f53a@ozlabs.ru> (raw)
In-Reply-To: <95395244-bdec-84d2-b81b-3040c076fe4d@ozlabs.ru>
On 07/04/2020 20:12, Alexey Kardashevskiy wrote:
>
>
> On 07/04/2020 03:17, Christoph Hellwig wrote:
>> On Mon, Apr 06, 2020 at 11:25:09PM +1000, Alexey Kardashevskiy wrote:
>>>>> Do you see any serious problem with this approach? Thanks!
>>>>
>>>> Do you have a link to the whole branch? The github UI is unfortunately
>>>> unusable for that (or I'm missing something).
>>>
>>> The UI shows the branch but since I rebased and forcepushed it, it does
>>> not. Here is the current one with:
>>>
>>> https://github.com/aik/linux/commits/dma-bypass.3
>>
>> Ok, so we use the core bypass without persistent memory, and then
>> have another bypass mode on top. Not great, but I can't think
>> of anything better. Note that your checks for the map_sg case
>> aren't very efficient - for one it would make sense to calculate
>> the limit only once,
>
> Good points, I'll post revised version when you post your v3 of this.
Any plans on posting v3 of this? Thanks,
>
>> but also it would make sense to reuse the
>> calculted diecect mapping addresses instead of doing another pass
>> later on in the dma-direct code.
>
> Probably but I wonder what kind of hardware we need to see the
> difference. I might try, just need to ride to the office to plug the
> cable in my 100GBit eth machines :) Thanks,
>
>
--
Alexey
next prev parent reply other threads:[~2020-04-14 6:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 14:16 generic DMA bypass flag v2 Christoph Hellwig
2020-03-20 14:16 ` [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device Christoph Hellwig
2020-03-20 15:02 ` Greg Kroah-Hartman
2020-03-23 1:28 ` Alexey Kardashevskiy
2020-03-23 8:37 ` Christoph Hellwig
2020-03-23 8:50 ` Christoph Hellwig
2020-03-23 15:37 ` Aneesh Kumar K.V
2020-03-23 17:22 ` Christoph Hellwig
2020-03-24 3:05 ` Alexey Kardashevskiy
2020-03-24 6:30 ` Aneesh Kumar K.V
2020-03-24 7:55 ` Christoph Hellwig
2020-03-24 7:54 ` Christoph Hellwig
2020-03-25 4:51 ` Alexey Kardashevskiy
2020-03-25 8:37 ` Christoph Hellwig
2020-03-26 1:26 ` Alexey Kardashevskiy
2020-04-03 8:38 ` Alexey Kardashevskiy
2020-04-06 11:50 ` Christoph Hellwig
2020-04-06 13:25 ` Alexey Kardashevskiy
2020-04-06 17:17 ` Christoph Hellwig
2020-04-07 10:12 ` Alexey Kardashevskiy
2020-04-14 6:21 ` Alexey Kardashevskiy [this message]
2020-04-14 6:30 ` Christoph Hellwig
2020-03-23 8:58 ` Alexey Kardashevskiy
2020-03-23 17:20 ` Christoph Hellwig
2020-03-24 3:37 ` Alexey Kardashevskiy
2020-03-24 4:55 ` Alexey Kardashevskiy
2020-03-24 7:52 ` Christoph Hellwig
2020-03-23 12:14 ` Robin Murphy
2020-03-23 12:55 ` Christoph Hellwig
2020-03-20 14:16 ` [PATCH 2/2] powerpc: use the generic dma_ops_bypass mode Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-03-24 9:39 [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to, struct device Christian Zigotzky
2019-11-13 13:37 generic DMA bypass flag Christoph Hellwig
2019-11-13 13:37 ` [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ad32a4-7ce5-4f4d-8237-53356f76f53a@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=aneesh.kumar@linux.ibm.com \
--cc=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).