From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: Mathieu Malaterre <malat@debian.org>,
hch@infradead.org, mikey@neuling.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 1/2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool
Date: Fri, 5 Jul 2019 01:52:44 +1000 (AEST) [thread overview]
Message-ID: <45fjDD6cxvz9sNw@ozlabs.org> (raw)
In-Reply-To: <20190604030037.9424-1-mikey@neuling.org>
On Tue, 2019-06-04 at 03:00:36 UTC, Michael Neuling wrote:
> From: Mathieu Malaterre <malat@debian.org>
>
> In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9
> option") the following piece of code was added:
>
> smp_call_function((smp_call_func_t)set_dawr, &null_brk, 0);
>
> Since GCC 8 this triggers the following warning about incompatible
> function types:
>
> arch/powerpc/kernel/hw_breakpoint.c:408:21: error: cast between incompatible function types from 'int (*)(struct arch_hw_breakpoint *)' to 'void (*)(void *)' [-Werror=cast-function-type]
>
> Since the warning is there for a reason, and should not be hidden behind
> a cast, provide an intermediate callback function to avoid the warning.
>
> Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option")
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/548c54acba5bd1388d50727a9a126a42d0cd4ad0
cheers
prev parent reply other threads:[~2019-07-04 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 3:00 [PATCH v5 1/2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool Michael Neuling
2019-06-04 3:00 ` [PATCH v5 2/2] powerpc: Fix compile issue with force DAWR Michael Neuling
2019-06-18 16:28 ` Christophe Leroy
2019-06-19 1:11 ` Michael Neuling
2019-06-19 18:03 ` Christophe Leroy
2019-07-04 15:52 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45fjDD6cxvz9sNw@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=hch@infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).