From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>, linuxppc-dev@lists.ozlabs.org
Cc: ajd@linux.ibm.com, npiggin@gmail.com,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 1/2] powerpc/book3s64/hash: Disable 16M linear mapping size if not aligned
Date: Wed, 29 Jan 2020 16:17:28 +1100 (AEDT) [thread overview]
Message-ID: <486sDm3Clwz9sRW@ozlabs.org> (raw)
In-Reply-To: <20191224064126.183670-1-ruscur@russell.cc>
On Tue, 2019-12-24 at 06:41:25 UTC, Russell Currey wrote:
> With STRICT_KERNEL_RWX on in a relocatable kernel under the hash MMU, if
> the position the kernel is loaded at is not 16M aligned, the kernel
> miscalculates its ALIGN*()s and things go horribly wrong.
>
> We can easily avoid this when selecting the linear mapping size, so do
> so and print a warning. I tested this for various alignments and as
> long as the position is 64K aligned it's fine (the base requirement for
> powerpc).
>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/970d54f99ceac5bbf27929cb5ebfe18338ba1543
cheers
prev parent reply other threads:[~2020-01-29 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 6:41 [PATCH 1/2] powerpc/book3s64/hash: Disable 16M linear mapping size if not aligned Russell Currey
2019-12-24 6:41 ` [PATCH 2/2] powerpc: Remove STRICT_KERNEL_RWX incompatibility with RELOCATABLE Russell Currey
2020-01-29 5:17 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486sDm3Clwz9sRW@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).