linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: solution to printk() blocking interrupts?
Date: Mon, 22 Sep 2008 15:01:20 +0400	[thread overview]
Message-ID: <48D77B00.2050606@ru.mvista.com> (raw)
In-Reply-To: <48D76D6E.2020002@ru.mvista.com>

Hello, I wrote:

>> diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
>> index 4e4f683..72541b5 100644
>> --- a/drivers/net/fec_mpc52xx.c
>> +++ b/drivers/net/fec_mpc52xx.c
>> @@ -401,6 +401,16 @@ static int mpc52xx_fec_hard_start_xmit(struct
>> sk_buff *skb, struct net_device *d
>>         return 0;
>>  }
>>
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void mpc52xx_fec_poll_controller(struct net_device *dev)
>> +{
>> +        disable_irq(dev->irq);
>> +        mpc52xx_fec_tx_interrupt(dev->irq, dev);
>>   
>
>   The interrupt nu,ber seems wrong, although the handler doesn't care 
> anyway...
>
>> +        enable_irq(dev->irq);

   Ah, you're also dis/enabling the wrong IRQ -- it should be 
priv->t_irq. No, this patch won't do.

WBR, Sergei

  reply	other threads:[~2008-09-22 11:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-21 20:53 solution to printk() blocking interrupts? Jon Smirl
2008-09-21 21:43 ` Jon Smirl
2008-09-21 22:21   ` Sergei Shtylyov
2008-09-21 23:34     ` Jon Smirl
2008-09-22  5:17       ` Benjamin Herrenschmidt
2008-09-22 11:04         ` Sergei Shtylyov
2008-09-22 11:11           ` Sergei Shtylyov
2008-09-22 14:39             ` Sergei Shtylyov
2008-09-22 14:45               ` Jon Smirl
2008-09-22 14:59                 ` Sergei Shtylyov
2008-09-22 21:27             ` Benjamin Herrenschmidt
2008-09-22 10:03       ` Sergei Shtylyov
2008-09-22 11:01         ` Sergei Shtylyov [this message]
2008-09-22 11:21   ` Sergei Shtylyov
2008-09-22 13:45     ` Jon Smirl
2008-09-23  5:46       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D77B00.2050606@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=Linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).