From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, dan.j.williams@intel.com,
Li Yang <leoli@freescale.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module
Date: Thu, 25 Sep 2008 15:16:44 -0500 [thread overview]
Message-ID: <48DBF1AC.9060909@freescale.com> (raw)
In-Reply-To: <48DBE1E1.6030709@freescale.com>
Timur Tabi wrote:
> Scott Wood wrote:
>
>>> I chose subsys_initcall() to increase the probability that fsldma is
>>> already present when DMA clients are loaded/initialized and register.
>> If there's no dependency, why does it matter whether fsldma is already
>> present?
>
> Re-read my explanation, please.
I read it just fine the first time.
> Technically, it doesn't *matter* in that
> nothing will break, but so what? It's nicer if the DMA driver is already
> available when the client drivers load, so that they can use the DMA facilities
> right away.
It's not nicer to people reading the code and wondering why, or to
people who use it as a module and execute less-well-tested code paths,
and I doubt it's a significant addition to boot time to do things in the
normal way.
I'm not particularly worried about the code going on strike because
we're not being "nice" to it.
-Scott
next prev parent reply other threads:[~2008-09-25 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 21:59 [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module Timur Tabi
2008-09-25 6:54 ` Li Yang
2008-09-25 13:54 ` Timur Tabi
2008-09-25 18:40 ` Scott Wood
2008-09-25 18:47 ` Timur Tabi
2008-09-25 19:00 ` Scott Wood
2008-09-25 19:09 ` Timur Tabi
2008-09-25 20:16 ` Scott Wood [this message]
2008-09-27 18:13 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DBF1AC.9060909@freescale.com \
--to=scottwood@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).