Re: Argh, can't find dcache properties !

[Qian Cai <cai@lca.pw>]

> On Mar 24, 2020, at 4:06 PM, Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
> 
> On Tue, 2020-03-24 at 15:47 +1100, Michael Ellerman wrote:
>> Chris Packham <Chris.Packham@alliedtelesis.co.nz> writes:
>>> Hi All,
>>> 
>>> Just booting up v5.5.11 on a Freescale T2080RDB and I'm seeing the
>>> following mesage.
>>> 
>>> kern.warning linuxbox kernel: Argh, can't find dcache properties !
>>> kern.warning linuxbox kernel: Argh, can't find icache properties !
>>> 
>>> This was changed from DBG() to pr_warn() in commit 3b9176e9a874
>>> ("powerpc/setup_64: fix -Wempty-body warnings") but the message
>>> seems
>>> to be much older than that. So it's probably been an issue on the
>>> T2080
>>> (and other QorIQ SoCs) for a while.
>> 
>> That's an e6500 I think? So 64-bit Book3E.
>> 
> 
> Yes that's correct.
> 
>> You'll be getting the default values, which is 64 bytes so I guess
>> that
>> works in practice.
>> 
>>> Looking at the code the t208x doesn't specifiy any of the d-cache-
>>> size/i-cache-size properties. Should I add them to silence the
>>> warning
>>> or switch it to pr_debug()/pr_info()?
>> 
>> Yeah ideally you'd add them to the device tree(s) for those boards.
>> 
> 
> I think the info I need is in the block diagram[0]. I'll whip up
> a patch.
> 
> --
> [1] - https://www.nxp.com/products/processors-and-microcontrollers/power-architecture/qoriq-communication-processors/t-series/qoriq-t2080-and-t2081-multicore-communications-processors:T2080

BTW, POWER9 PowerNV would have the same thing. 

[    0.000000][    T0] Setting debug_guardpage_minorder to 1
[    0.000000][    T0] Reserving 512MB of memory at 128MB for crashkernel (System RAM: 262144MB)
[    0.000000][    T0] radix-mmu: Page sizes from device-tree:
[    0.000000][    T0] radix-mmu: Page size shift = 12 AP=0x0
[    0.000000][    T0] radix-mmu: Page size shift = 16 AP=0x5
[    0.000000][    T0] radix-mmu: Page size shift = 21 AP=0x1
[    0.000000][    T0] radix-mmu: Page size shift = 30 AP=0x2
[    0.000000][    T0] radix-mmu: Activating Kernel Userspace Execution Prevention
[    0.000000][    T0] radix-mmu: Activating Kernel Userspace Access Prevention
[    0.000000][    T0] radix-mmu: Mapped 0x0000000000000000-0x0000000001600000 with 2.00 MiB pages (exec)
[    0.000000][    T0] radix-mmu: Mapped 0x0000000001600000-0x0000000040000000 with 2.00 MiB pages
[    0.000000][    T0] radix-mmu: Mapped 0x0000000040000000-0x0000002000000000 with 1.00 GiB pages
[    0.000000][    T0] radix-mmu: Mapped 0x0000200000000000-0x0000202000000000 with 1.00 GiB pages
[    0.000000][    T0] radix-mmu: Initializing Radix MMU
[    0.000000][    T0] Linux version 5.6.0-rc7-next-20200324+ (root@ibm-p9wr) (gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC)) #2 SMP Tue Mar 24 15:52:36 EDT 2020
[    0.000000][    T0] Argh, can't find dcache properties !
[    0.000000][    T0] Argh, can't find icache properties !
[    0.000000][    T0] Found initrd at 0xc000000007850000:0xc00000000ad26142
[    0.000000][    T0] OPAL: Found memory mapped LPC bus on chip 0
[    0.000000][    T0] Using PowerNV machine description
[    0.000000][    T0] printk: bootconsole [udbg0] enabled
[    0.000000][    T0] CPU maps initialized for 4 threads per core
[    0.000000][    T0] -----------------------------------------------------
[    0.000000][    T0] phys_mem_size     = 0x4000000000
[    0.000000][    T0] dcache_bsize      = 0x80
[    0.000000][    T0] icache_bsize      = 0x80
[    0.000000][    T0] cpu_features      = 0x0001f86f8f5fb1a7
[    0.000000][    T0]   possible        = 0x0003fbffcf5fb1a7
[    0.000000][    T0]   always          = 0x0000006f8b5c91a1
[    0.000000][    T0] cpu_user_features = 0xdc0065c2 0xaee00000
[    0.000000][    T0] mmu_features      = 0xbc006041
[    0.000000][    T0] firmware_features = 0x0000000010000000
[    0.000000][    T0] vmalloc start     = 0xc008000000000000
[    0.000000][    T0] IO start          = 0xc00a000000000000
[    0.000000][    T0] vmemmap start     = 0xc00c000000000000
[    0.000000][    T0] -----------------------------------------------------