From: Rini van Zetten <rini@arvoo.nl>
To: Kumar Gala <galak@kernel.crashing.org>,
spi-devel-general@lists.sourceforge.net,
linuxppc-dev list <Linuxppc-dev@ozlabs.org>
Subject: [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs.
Date: Thu, 18 Jun 2009 08:19:44 +0200 [thread overview]
Message-ID: <4A39DC80.7030906@arvoo.nl> (raw)
This patch adds the possibility to have a spi device without a cs.
For example, the dts file should look something like this:
spi-controller {
gpios = <&pio1 1 0 /* cs0 */
0 /* cs1, no GPIO */
&pio2 2 0>; /* cs2 */
Signed-off-by: Rini van Zetten <rini@arvoo.nl>
---
Changes :
patch against 2.6.30-rc8-mm1
--- drivers/spi/spi_mpc8xxx.c.org 2009-06-12 10:45:21.000000000 +0200
+++ drivers/spi/spi_mpc8xxx.c 2009-06-12 10:54:48.000000000 +0200
@@ -666,9 +666,10 @@ static void mpc8xxx_spi_cs_control(struc
struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
u16 cs = spi->chip_select;
int gpio = pinfo->gpios[cs];
- bool alow = pinfo->alow_flags[cs];
-
- gpio_set_value(gpio, on ^ alow);
+ if (gpio != -EEXIST) {
+ bool alow = pinfo->alow_flags[cs];
+ gpio_set_value(gpio, on ^ alow);
+ }
}
static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
@@ -707,27 +708,29 @@ static int of_mpc8xxx_spi_get_chipselect
enum of_gpio_flags flags;
gpio = of_get_gpio_flags(np, i, &flags);
- if (!gpio_is_valid(gpio)) {
+ if (gpio_is_valid(gpio)) {
+ ret = gpio_request(gpio, dev_name(dev));
+ if (ret) {
+ dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
+ goto err_loop;
+ }
+
+ pinfo->gpios[i] = gpio;
+ pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
+
+ ret = gpio_direction_output(pinfo->gpios[i],
+ pinfo->alow_flags[i]);
+ if (ret) {
+ dev_err(dev, "can't set output direction for gpio "
+ "#%d: %d\n", i, ret);
+ goto err_loop;
+ }
+ } else if (gpio == -EEXIST) {
+ pinfo->gpios[i] = -EEXIST;
+ } else {
dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
goto err_loop;
}
-
- ret = gpio_request(gpio, dev_name(dev));
- if (ret) {
- dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
- goto err_loop;
- }
-
- pinfo->gpios[i] = gpio;
- pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
-
- ret = gpio_direction_output(pinfo->gpios[i],
- pinfo->alow_flags[i]);
- if (ret) {
- dev_err(dev, "can't set output direction for gpio "
- "#%d: %d\n", i, ret);
- goto err_loop;
- }
}
pdata->max_chipselect = ngpios;
--
--
Rini van Zetten
Senior Software Engineer
-------------------------
ARVOO Engineering B.V.
Tasveld 13
3417 XS Montfoort
The Netherlands
E-mail : <mailto:rini@arvoo.com> Rini van Zetten
Web : www.arvoo.com
next reply other threads:[~2009-06-18 6:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 6:19 Rini van Zetten [this message]
2009-06-18 12:42 ` [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs Kumar Gala
2009-06-18 13:09 ` Anton Vorontsov
2009-06-18 14:04 ` Kumar Gala
2009-06-19 7:26 ` [PATCH -mm v3][POWERPC] " Rini van Zetten
2009-06-19 7:45 ` Kumar Gala
2009-06-19 11:16 ` Rini van Zetten
2009-06-19 13:45 ` Anton Vorontsov
2009-06-19 14:18 ` [PATCH -mm v4][POWERPC] " Rini van Zetten
2009-07-03 1:38 ` [spi-devel-general] " David Brownell
2009-06-19 11:45 ` [PATCH -mm][POWERPC] " Leon Woestenberg
2009-06-19 13:25 ` Anton Vorontsov
2009-06-19 15:31 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2009-06-11 9:10 [PATCH][POWERPC] mpc83xx " Rini van Zetten
2009-06-11 13:29 ` Kumar Gala
2009-06-12 8:59 ` [PATCH -mm][POWERPC] mpc8xxx " Rini van Zetten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A39DC80.7030906@arvoo.nl \
--to=rini@arvoo.nl \
--cc=Linuxppc-dev@ozlabs.org \
--cc=galak@kernel.crashing.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).