From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
KVM list <kvm@vger.kernel.org>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 18/26] KVM: PPC: KVM PV guest stubs
Date: Sun, 27 Jun 2010 11:28:40 +0300 [thread overview]
Message-ID: <4C270BB8.60404@redhat.com> (raw)
In-Reply-To: <1277508314-915-19-git-send-email-agraf@suse.de>
On 06/26/2010 02:25 AM, Alexander Graf wrote:
> We will soon start and replace instructions from the text section with
> other, paravirtualized versions. To ease the readability of those patches
> I split out the generic looping and magic page mapping code out.
>
> This patch still only contains stubs. But at least it loops through the
> text section :).
>
>
> +
> +static void kvm_check_ins(u32 *inst)
> +{
> + u32 _inst = *inst;
> + u32 inst_no_rt = _inst& ~KVM_MASK_RT;
> + u32 inst_rt = _inst& KVM_MASK_RT;
> +
> + switch (inst_no_rt) {
> + }
> +
> + switch (_inst) {
> + }
> +
> + flush_icache_range((ulong)inst, (ulong)inst + 4);
> +}
>
Shouldn't we flush only if we patched something?
> +
> +static void kvm_use_magic_page(void)
> +{
> + u32 *p;
> + u32 *start, *end;
> +
> + /* Tell the host to map the magic page to -4096 on all CPUs */
> +
> + on_each_cpu(kvm_map_magic_page, NULL, 1);
> +
> + /* Now loop through all code and find instructions */
> +
> + start = (void*)_stext;
> + end = (void*)_etext;
> +
> + for (p = start; p< end; p++)
> + kvm_check_ins(p);
> +}
> +
>
Or, flush the entire thing here.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-27 8:28 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 23:24 [PATCH 00/26] KVM PPC PV framework Alexander Graf
2010-06-25 23:24 ` [PATCH 01/26] KVM: PPC: Introduce shared page Alexander Graf
2010-06-27 12:12 ` Avi Kivity
2010-06-29 9:54 ` Alexander Graf
2010-06-29 10:55 ` Avi Kivity
2010-06-25 23:24 ` [PATCH 02/26] KVM: PPC: Convert MSR to " Alexander Graf
2010-06-27 8:16 ` Avi Kivity
2010-06-27 9:38 ` Alexander Graf
2010-06-27 9:50 ` Avi Kivity
2010-06-27 10:40 ` Alexander Graf
2010-06-25 23:24 ` [PATCH 03/26] KVM: PPC: Convert DSISR " Alexander Graf
2010-06-25 23:24 ` [PATCH 04/26] KVM: PPC: Convert DAR " Alexander Graf
2010-06-25 23:24 ` [PATCH 05/26] KVM: PPC: Convert SRR0 and SRR1 " Alexander Graf
2010-06-25 23:24 ` [PATCH 06/26] KVM: PPC: Convert SPRG[0-4] " Alexander Graf
2010-06-25 23:24 ` [PATCH 07/26] KVM: PPC: Implement hypervisor interface Alexander Graf
2010-06-25 23:24 ` [PATCH 08/26] KVM: PPC: Add PV guest critical sections Alexander Graf
2010-06-27 8:21 ` Avi Kivity
2010-06-27 9:40 ` Alexander Graf
2010-06-27 9:52 ` Avi Kivity
2010-06-27 10:33 ` Alexander Graf
2010-06-27 10:59 ` Avi Kivity
2010-06-27 11:49 ` Alexander Graf
2010-06-27 11:53 ` Avi Kivity
2010-06-27 12:06 ` Alexander Graf
2010-06-27 22:03 ` Benjamin Herrenschmidt
2010-06-27 10:03 ` Avi Kivity
2010-06-27 10:35 ` Alexander Graf
2010-06-25 23:24 ` [PATCH 09/26] KVM: PPC: Add PV guest scratch registers Alexander Graf
2010-06-27 8:22 ` Avi Kivity
2010-06-27 9:41 ` Alexander Graf
2010-06-27 9:53 ` Avi Kivity
2010-06-25 23:24 ` [PATCH 10/26] KVM: PPC: Tell guest about pending interrupts Alexander Graf
2010-06-25 23:24 ` [PATCH 11/26] KVM: PPC: Make RMO a define Alexander Graf
2010-06-26 16:52 ` Segher Boessenkool
2010-06-27 9:08 ` Alexander Graf
2010-06-29 7:32 ` Segher Boessenkool
2010-06-29 7:39 ` Alexander Graf
2010-06-29 7:52 ` Segher Boessenkool
2010-06-29 8:04 ` Alexander Graf
2010-06-25 23:25 ` [PATCH 12/26] KVM: PPC: First magic page steps Alexander Graf
2010-06-27 8:24 ` Avi Kivity
2010-06-27 9:44 ` Alexander Graf
2010-06-25 23:25 ` [PATCH 13/26] KVM: PPC: Magic Page Book3s support Alexander Graf
2010-06-25 23:25 ` [PATCH 14/26] KVM: PPC: Magic Page BookE support Alexander Graf
2010-06-25 23:25 ` [PATCH 15/26] KVM: PPC: Expose magic page support to guest Alexander Graf
2010-06-25 23:25 ` [PATCH 16/26] KVM: Move kvm_guest_init out of generic code Alexander Graf
2010-06-25 23:25 ` [PATCH 17/26] KVM: PPC: Generic KVM PV guest support Alexander Graf
2010-06-25 23:25 ` [PATCH 18/26] KVM: PPC: KVM PV guest stubs Alexander Graf
2010-06-27 8:28 ` Avi Kivity [this message]
2010-06-27 9:47 ` Alexander Graf
2010-06-27 10:16 ` Avi Kivity
2010-06-27 10:38 ` Alexander Graf
2010-06-27 22:04 ` Benjamin Herrenschmidt
2010-06-28 4:39 ` Matt Evans
2010-06-28 6:33 ` Alexander Graf
2010-06-28 8:15 ` Avi Kivity
2010-06-28 8:23 ` Alexander Graf
2010-06-28 8:33 ` Avi Kivity
2010-06-25 23:25 ` [PATCH 19/26] KVM: PPC: PV instructions to loads and stores Alexander Graf
2010-06-25 23:25 ` [PATCH 20/26] KVM: PPC: PV tlbsync to nop Alexander Graf
2010-06-25 23:25 ` [PATCH 21/26] KVM: PPC: Introduce kvm_tmp framework Alexander Graf
2010-06-25 23:25 ` [PATCH 22/26] KVM: PPC: PV assembler helpers Alexander Graf
2010-06-25 23:25 ` [PATCH 23/26] KVM: PPC: PV mtmsrd L=1 Alexander Graf
2010-06-25 23:25 ` [PATCH 24/26] KVM: PPC: PV mtmsrd L=0 and mtmsr Alexander Graf
2010-06-26 17:03 ` Segher Boessenkool
2010-06-27 9:10 ` Alexander Graf
2010-06-29 7:37 ` Segher Boessenkool
2010-06-25 23:25 ` [PATCH 25/26] KVM: PPC: PV wrteei Alexander Graf
2010-06-25 23:25 ` [PATCH 26/26] KVM: PPC: Add Documentation about PV interface Alexander Graf
2010-06-27 8:14 ` Avi Kivity
2010-06-27 9:33 ` Alexander Graf
[not found] ` <4C270876.2050806%40redhat.com>
2010-06-28 7:18 ` Milton Miller
2010-06-28 7:49 ` Alexander Graf
2010-06-28 8:13 ` Avi Kivity
2010-06-28 8:21 ` Alexander Graf
2010-06-28 8:32 ` Avi Kivity
2010-06-27 8:34 ` Avi Kivity
2010-06-27 9:49 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C270BB8.60404@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).