linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>,
	"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate
Date: Mon, 04 Jul 2011 14:22:59 +0300	[thread overview]
Message-ID: <4E11A293.2010505@redhat.com> (raw)
In-Reply-To: <40F62A22-6A47-4414-8FF9-0534568353DA@suse.de>

On 07/04/2011 01:59 PM, Alexander Graf wrote:
> On 03.07.2011, at 11:12, Avi Kivity wrote:
>
> >  On 07/03/2011 12:09 PM, Alexander Graf wrote:
> >>  >
> >>  >   Right.  The idea is that if KVM_FLAG_BLAH implies a field kvm_struct::blah, then either both are present in the headers, or none  of them.
> >>
> >>  Yup, makes sense. I like the idea :). Gets rid of all the useless paddings and reserved fields. We could even truncate the structs that already have paddings in them if we only copy min(sizeof(real_struct), ioctl_passed_size); (which we should anyways).
> >>
> >
> >  No, we can't change anything that is already out.  If will change the ioctl numbers, so building against new headers but running against an old kernel will fail.
>
> So this will only be enabled for completely new ioctls?

Yes, unfortunately.

> >
> >>  How long until we get a patch set? :)
> >
> >  Well, I'd really like to get the qemu memory API out first.
>
> Can we add the ioctl without padding now then and add your awesome extensibility stuff to it later on?

Yes.

> We only have to make sure we don't actually release the intermediate steps as an upstream kernel then, right?

What intermediate steps?  We can't add fields to the structure before we 
get the extensibility infrastructure, but that's all.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-07-04 11:23 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 10:15 [PATCH 0/17] Hypervisor-mode KVM on POWER7 and PPC970 Paul Mackerras
2011-06-29 10:16 ` [PATCH 01/17] KVM: PPC: Fix machine checks on 32-bit Book3S Paul Mackerras
2011-07-01 10:08   ` Alexander Graf
2011-06-29 10:17 ` [PATCH 02/17] KVM: PPC: Move fields between struct kvm_vcpu_arch and kvmppc_vcpu_book3s Paul Mackerras
2011-06-29 10:17 ` [PATCH 03/17] KVM: PPC: Split out code from book3s.c into book3s_pr.c Paul Mackerras
2011-06-29 10:18 ` [PATCH 04/17] powerpc, KVM: Rework KVM checks in first-level interrupt handlers Paul Mackerras
2011-06-29 10:18 ` [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them Paul Mackerras
2011-07-01 11:47   ` Alexander Graf
2011-06-29 10:19 ` [PATCH 06/17] KVM: PPC: Pass init/destroy vm and prepare/commit memory region ops down Paul Mackerras
2011-06-29 10:19 ` [PATCH 07/17] KVM: PPC: Move guest enter/exit down into subarch-specific code Paul Mackerras
2011-06-29 10:20 ` [PATCH 08/17] powerpc: Set up LPCR for running guest partitions Paul Mackerras
2011-06-29 10:20 ` [PATCH 09/17] KVM: PPC: Split host-state fields out of kvmppc_book3s_shadow_vcpu Paul Mackerras
2011-06-29 10:21 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in hypervisor mode Paul Mackerras
2011-07-01 18:37   ` Dave Hansen
2011-07-01 19:12     ` Alexander Graf
2011-07-04 11:51     ` Paul Mackerras
2011-06-29 10:22 ` [PATCH 11/17] KVM: PPC: Handle some PAPR hcalls in the kernel Paul Mackerras
2011-06-29 10:22 ` [PATCH 12/17] KVM: PPC: Accelerate H_PUT_TCE by implementing it in real mode Paul Mackerras
2011-06-29 10:23 ` [PATCH 13/17] KVM: PPC: Allow book3s_hv guests to use SMT processor modes Paul Mackerras
2012-04-16  9:45   ` Alexander Graf
2012-04-16 12:13     ` Paul Mackerras
2012-04-16 13:01       ` Alexander Graf
2011-06-29 10:25 ` [PATCH 14/17] KVM: PPC: Allocate RMAs (Real Mode Areas) at boot for use by guests Paul Mackerras
2011-06-29 10:26 ` [PATCH 15/17] powerpc, KVM: Split HVMODE_206 cpu feature bit into separate HV and architecture bits Paul Mackerras
2011-06-29 10:40 ` [PATCH 16/17] KVM: PPC: book3s_hv: Add support for PPC970-family processors Paul Mackerras
2011-06-29 10:41 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Paul Mackerras
2011-06-29 11:53   ` Josh Boyer
2011-06-29 11:56     ` Alexander Graf
2011-06-29 11:58       ` Josh Boyer
2011-06-30  8:34         ` Avi Kivity
2011-06-30 15:04   ` Alexander Graf
2011-06-30 15:16     ` Avi Kivity
2011-06-30 15:22       ` Alexander Graf
2011-06-30 16:00         ` Avi Kivity
2011-06-30 16:33           ` Alexander Graf
2011-07-03  8:15             ` Avi Kivity
2011-07-03  8:34               ` Alexander Graf
2011-07-03  8:56                 ` Avi Kivity
2011-07-03  9:00                   ` Alexander Graf
2011-07-03  9:05                     ` Avi Kivity
2011-07-03  9:09                       ` Alexander Graf
2011-07-03  9:12                         ` Avi Kivity
2011-07-04 10:59                           ` Alexander Graf
2011-07-04 11:22                             ` Avi Kivity [this message]
2011-07-04 11:36                               ` Alexander Graf
2011-07-04 11:37                                 ` Avi Kivity
2011-07-04 11:41                                   ` Alexander Graf
2011-06-30 23:13       ` Benjamin Herrenschmidt
2011-07-01 10:09     ` Paul Mackerras
2011-07-01 10:23       ` Alexander Graf
2011-07-01 18:24 ` [PATCH 0/17] Hypervisor-mode KVM on POWER7 and PPC970 Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E11A293.2010505@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).