From: Wolfgang Grandegger <wg@grandegger.com>
To: Robin Holt <holt@sgi.com>
Cc: "socketcan-core@lists.berlios.de"
<socketcan-core@lists.berlios.de>,
U Bhaskar-B22300 <B22300@freescale.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.
Date: Tue, 09 Aug 2011 17:10:32 +0200 [thread overview]
Message-ID: <4E414DE8.4050909@grandegger.com> (raw)
In-Reply-To: <20110809145507.GY4926@sgi.com>
On 08/09/2011 04:55 PM, Robin Holt wrote:
> On Tue, Aug 09, 2011 at 02:45:58PM +0000, U Bhaskar-B22300 wrote:
>> Hi Robin,
>> Where are you doing the irq handling ie request_irq() for the powerpc based P1010.
>> Or the existing code of ARM based FlexCAN will work for P1010 ??
>
> It appears that the of_device stuff got moved under the struct device
> and that allows the request_irq() to just magically work.
Cool! Actually I was also missing of_address_to_resource (or of_iomap)
and irq_of_parse_and_map(). But the resources seem to be filled in here:
http://lxr.linux.no/#linux+v3.0.1/drivers/of/platform.c#L121
Wolfgang.
next prev parent reply other threads:[~2011-08-09 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 12:28 [Patch 0/4] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V8 Robin Holt
2011-08-09 12:28 ` [PATCH 1/4] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-09 12:28 ` [PATCH 2/4] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-09 12:28 ` [PATCH 3/4] [flexcan] Add of_match to platform_device definition Robin Holt
2011-08-09 12:28 ` [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb Robin Holt
2011-08-09 13:00 ` Wolfgang Grandegger
2011-08-09 14:45 ` U Bhaskar-B22300
2011-08-09 14:55 ` Robin Holt
2011-08-09 15:10 ` Wolfgang Grandegger [this message]
2011-08-09 15:11 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E414DE8.4050909@grandegger.com \
--to=wg@grandegger.com \
--cc=B22300@freescale.com \
--cc=holt@sgi.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).