linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 2/4] Use for_each_node_with_property() in of_irq_map_init()
Date: Thu, 13 Nov 2008 15:20:37 +1100 (EST)	[thread overview]
Message-ID: <4ccd209b3cc7e9a3b05686843509ea3fa6843a37.1226550015.git.michael@ellerman.id.au> (raw)
In-Reply-To: <2743c30c538d24a0befee055bd6e0fcd746d0e82.1226550015.git.michael@ellerman.id.au>

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/kernel/prom_parse.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
index bc1fb27..2a1c02c 100644
--- a/arch/powerpc/kernel/prom_parse.c
+++ b/arch/powerpc/kernel/prom_parse.c
@@ -731,10 +731,7 @@ void of_irq_map_init(unsigned int flags)
 	if (flags & OF_IMAP_NO_PHANDLE) {
 		struct device_node *np;
 
-		for(np = NULL; (np = of_find_all_nodes(np)) != NULL;) {
-			if (of_get_property(np, "interrupt-controller", NULL)
-			    == NULL)
-				continue;
+		for_each_node_with_property(np, "interrupt-controller") {
 			/* Skip /chosen/interrupt-controller */
 			if (strcmp(np->name, "chosen") == 0)
 				continue;
-- 
1.5.5

  reply	other threads:[~2008-11-13  4:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13  4:20 [PATCH 1/4] Add helpers for finding a device node which as a certain property Michael Ellerman
2008-11-13  4:20 ` Michael Ellerman [this message]
2008-11-13  4:20 ` [PATCH 3/4] Use of_find_node_with_property() in cell_iommu_fixed_mapping_init() Michael Ellerman
2008-11-13  4:20 ` [PATCH 4/4] Use of_find_node_with_property() in pmac_setup_arch() Michael Ellerman
2008-11-13  9:27   ` Benjamin Herrenschmidt
2008-11-13  6:46 ` [PATCH 1/4] Add helpers for finding a device node which as a certain property David Miller
2008-11-13  6:49   ` Michael Ellerman
2008-11-13  7:11     ` Michael Ellerman
2008-11-13  7:31       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ccd209b3cc7e9a3b05686843509ea3fa6843a37.1226550015.git.michael@ellerman.id.au \
    --to=michael@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).