From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch@vger.kernel.org,
Darren Stevens <darren@stevens-zone.net>,
linux-kernel@vger.kernel.org, Julian Margetson <runaway@candw.ms>,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
Paul Mackerras <paulus@samba.org>,
Olof Johansson <olof@lixom.net>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: use generic DMA mapping code in powerpc V4
Date: Sun, 10 Feb 2019 13:00:20 +0100 [thread overview]
Message-ID: <4e7137db-e600-0d20-6fb2-6d0f9739aca3@xenosoft.de> (raw)
In-Reply-To: <20190208091818.GA23491@lst.de>
Hi Christoph,
On 08 February 2019 at 10:18AM, Christoph Hellwig wrote:
> On Fri, Feb 08, 2019 at 10:01:46AM +0100, Christian Zigotzky wrote:
>> Hi Christoph,
>>
>> Your new patch fixes the problems with the P.A. Semi Ethernet! :-)
> Thanks a lot once again for testing!
>
> Now can you test with this patch and the whole series?
>
> I've updated the powerpc-dma.6 branch to include this fix.
>
I tested the whole series today. The kernels boot and the P.A. Semi
Ethernet works! :-) Thanks a lot!
I also tested it in a virtual e5500 QEMU machine today. Unfortunately
the kernel crashes.
Log:
[ 54.624330] BUG: Unable to handle kernel data access at
0xc06c008a0013014a
[ 54.625640] Faulting instruction address: 0xc000000000027e7c
[ 54.626140] Oops: Kernel access of bad area, sig: 11 [#1]
[ 54.626456] BE SMP NR_CPUS=4 QEMU e500
[ 54.626876] Modules linked in:
[ 54.627284] CPU: 1 PID: 1876 Comm: systemd-journal Not tainted
5.0.0-rc5-DMA_A1-X5000-54581-gda1d065-dirty #1
[ 54.627819] NIP: c000000000027e7c LR: c0000000000b5264 CTR:
0000000000000000
[ 54.628173] REGS: c00000007ffeb700 TRAP: 0300 Not tainted
(5.0.0-rc5-DMA_A1-X5000-54581-gda1d065-dirty)
[ 54.628607] MSR: 0000000080009000 <EE,ME> CR: 44008486 XER: 00000000
[ 54.629023] DEAR: c06c008a0013014a ESR: 0000000000800000 IRQMASK: 0
[ 54.629023] GPR00: 0000000000005254 c00000007ffeb990 c0000000016b2000
c06c008a0013014a
[ 54.629023] GPR04: c00000007c54f8c0 0000000000000058 0000000000000006
0000000000000000
[ 54.629023] GPR08: 0000000000000000 000000007c54f8c0 006c008a0013014a
c00000007c86c000
[ 54.629023] GPR12: 0000000028002482 c00000003ffff8c0 0000000000000000
c000000078dfaa70
[ 54.629023] GPR16: c000000078366c00 0000000000000000 000000000000005e
0000000000000000
[ 54.629023] GPR20: 0000000000000000 c00000007c54f8c0 0000000000000007
c000000078dfa000
[ 54.629023] GPR24: 0000000000000000 0000000000000047 0000000000000000
80000000003f6470
[ 54.629023] GPR28: c00000007928d470 c000000078801dc0 000000000000005e
c000000078dfa7c0
[ 54.632572] NIP [c000000000027e7c] .memcpy+0x1fc/0x288
[ 54.632886] LR [c0000000000b5264] .swiotlb_tbl_sync_single+0xb0/0xe4
[ 54.633221] Call Trace:
[ 54.633513] [c00000007ffeb990] [c00000007ffeba70] 0xc00000007ffeba70
(unreliable)
[ 54.633988] [c00000007ffeba00] [c0000000000b41e4]
.dma_direct_sync_single_for_cpu+0x58/0x6c
[ 54.634436] [c00000007ffeba70] [c000000000788da4]
.e1000_clean_rx_irq+0x1bc/0x4c8
[ 54.634857] [c00000007ffebb90] [c00000000078667c]
.e1000_clean+0x714/0x8d4
[ 54.635263] [c00000007ffebcc0] [c000000000a3f15c]
.net_rx_action+0x11c/0x2a4
[ 54.635712] [c00000007ffebdb0] [c000000000c48c20]
.__do_softirq+0x150/0x2a8
[ 54.636211] [c00000007ffebeb0] [c000000000064184] .irq_exit+0x6c/0xc4
[ 54.636533] [c00000007ffebf20] [c000000000004124] .__do_irq+0x80/0x94
[ 54.636985] [c00000007ffebf90] [c00000000000eca0] .call_do_irq+0x14/0x24
[ 54.637371] [c00000007c86fd80] [c0000000000041c0] .do_IRQ+0x88/0xc4
[ 54.637737] [c00000007c86fe20] [c000000000012920]
exc_0x500_common+0xd8/0xdc
[ 54.638104] Instruction dump:
[ 54.638451] e861fff8 4e800020 7cd01120 7ca62850 38e00000 28a50010
409f0010 88040000
[ 54.638887] 98030000 38e70001 409e0010 7c07222e <7c071b2e> 38e70002
409d000c 7c07202e
[ 54.639594] ---[ end trace a4861de7e4c199f7 ]---
[ 54.639873]
[ 55.640484] Kernel panic - not syncing: Aiee, killing interrupt handler!
[ 55.641556] Rebooting in 180 seconds..
-----
I tested with the following QEMU commands:
./qemu-system-ppc64 -M ppce500 -cpu e5500 -m 2048 -nographic -kernel
/home/christian/Downloads/vmlinux-5.0-rc5-2-AmigaOne_X1000_X5000/X5000_and_QEMU_e5500/uImage-5.0
-nic user,model=e1000 -drive
format=raw,file=/home/christian/Downloads/MATE_PowerPC_Remix_2017_0.9.img,index=0,if=virtio
-append "rw root=/dev/vda" -smp 4
./qemu-system-ppc64 -M ppce500 -cpu e5500 -m 2048 -kernel
/home/christian/Downloads/vmlinux-5.0-rc5-2-AmigaOne_X1000_X5000/X5000_and_QEMU_e5500/uImage-5.0
-drive
format=raw,file=/home/christian/Downloads/MATE_PowerPC_Remix_2017_0.9.img,index=0,if=virtio
-nic user,model=e1000 -append "rw root=/dev/vda" -device virtio-vga
-device virtio-mouse-pci -device virtio-keyboard-pci -usb -soundhw
es1370 -smp 4
The RC5 of kernel 5.0 boots without any problems in this virtual machine.
Cheers,
Christian
next prev parent reply other threads:[~2019-02-10 12:03 UTC|newest]
Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 8:22 use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-11-14 8:22 ` [PATCH 01/34] powerpc: use mm zones more sensibly Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-12-07 12:18 ` Michael Ellerman
2018-12-07 14:09 ` Christoph Hellwig
2018-12-07 15:04 ` Christian Zigotzky
2018-11-14 8:22 ` [PATCH 02/34] powerpc: allow NOT_COHERENT_CACHE for amigaone Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 03/34] powerpc/dma: remove the unused ARCH_HAS_DMA_MMAP_COHERENT define Christoph Hellwig
2018-12-06 14:09 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 04/34] powerpc/dma: remove the unused ISA_DMA_THRESHOLD export Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 05/34] powerpc/dma: remove the unused dma_iommu_ops export Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 06/34] powerpc/dma: split the two __dma_alloc_coherent implementations Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 07/34] powerpc/dma: remove the no-op dma_nommu_unmap_{page, sg} routines Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 08/34] powerpc/dma: untangle vio_dma_mapping_ops from dma_iommu_ops Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 09/34] powerpc/dma: handle iommu bypass in dma_iommu_ops Christoph Hellwig
2018-11-14 8:22 ` [PATCH 10/34] powerpc/pseries: unwind dma_get_required_mask_pSeriesLP a bit Christoph Hellwig
2018-11-14 8:22 ` [PATCH 11/34] powerpc/pseries: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 12/34] powerpc/cell: move dma direct window setup out of dma_configure Christoph Hellwig
2018-12-09 10:23 ` Michael Ellerman
2018-12-12 14:36 ` Christoph Hellwig
2018-12-14 13:29 ` Michael Ellerman
2018-12-14 16:42 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 13/34] powerpc/cell: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 14/34] powerpc/dart: remove dead cleanup code in iommu_init_early_dart Christoph Hellwig
2018-12-06 14:11 ` Christoph Hellwig
2018-11-14 8:22 ` [PATCH 15/34] powerpc/dart: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 16/34] powerpc/powernv: remove pnv_pci_ioda_pe_single_vendor Christoph Hellwig
2018-11-14 8:22 ` [PATCH 17/34] powerpc/powernv: remove pnv_npu_dma_set_mask Christoph Hellwig
2018-11-14 8:22 ` [PATCH 18/34] powerpc/powernv: use the generic iommu bypass code Christoph Hellwig
2018-11-14 8:22 ` [PATCH 19/34] cxl: drop the dma_set_mask callback from vphb Christoph Hellwig
2018-12-06 14:10 ` Christoph Hellwig
2018-11-14 8:23 ` [PATCH 20/34] powerpc/dma: stop overriding dma_get_required_mask Christoph Hellwig
2018-11-14 8:23 ` [PATCH 21/34] powerpc/pci: remove the dma_set_mask pci_controller ops methods Christoph Hellwig
2018-11-14 8:23 ` [PATCH 22/34] powerpc/dma: remove the iommu fallback for coherent allocations Christoph Hellwig
2018-11-14 8:23 ` [PATCH 23/34] powerpc/dma: remove get_pci_dma_ops Christoph Hellwig
2018-11-14 8:23 ` [PATCH 24/34] powerpc/dma: move pci_dma_dev_setup_swiotlb to fsl_pci.c Christoph Hellwig
2018-11-14 8:23 ` [PATCH 25/34] powerpc/dma: remove max_direct_dma_addr Christoph Hellwig
2018-11-14 8:23 ` [PATCH 26/34] powerpc/dma: fix an off-by-one in dma_capable Christoph Hellwig
2018-11-14 8:23 ` [PATCH 27/34] powerpc/fsl_pci: simplify fsl_pci_dma_set_mask Christoph Hellwig
2018-11-14 8:23 ` [PATCH 28/34] dma-mapping, powerpc: simplify the arch dma_set_mask override Christoph Hellwig
2018-11-14 8:23 ` [PATCH 29/34] powerpc/dma: use phys_to_dma instead of get_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 30/34] powerpc/dma: remove dma_nommu_mmap_coherent Christoph Hellwig
2018-11-14 8:23 ` [PATCH 31/34] powerpc/dma: use generic direct and swiotlb ops Christoph Hellwig
2018-11-14 8:23 ` [PATCH 32/34] powerpc/dma: remove get_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 33/34] powerpc/dma: remove set_dma_offset Christoph Hellwig
2018-11-14 8:23 ` [PATCH 34/34] powerpc/dma: trim the fat from <asm/dma-mapping.h> Christoph Hellwig
2018-11-27 7:42 ` use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-11-27 22:05 ` Benjamin Herrenschmidt
2018-11-28 11:05 ` Michael Ellerman
2018-11-28 15:55 ` Christian Zigotzky
2018-11-28 20:02 ` Christian Zigotzky
2018-11-28 20:35 ` Michal Suchánek
2018-11-29 17:03 ` Christoph Hellwig
2019-12-19 13:54 ` Christian Zigotzky
2018-11-29 12:05 ` Christian Zigotzky
2018-11-29 15:30 ` Christian Zigotzky
2018-11-29 17:03 ` Christoph Hellwig
2018-11-29 23:07 ` Christian Zigotzky
2018-11-30 10:53 ` Christoph Hellwig
2018-11-30 12:23 ` Christian Zigotzky
2018-11-30 13:10 ` Christoph Hellwig
2018-11-30 15:29 ` Christian Zigotzky
2018-12-04 7:31 ` Christian Zigotzky
2018-12-04 9:53 ` Christian Zigotzky
2018-12-04 14:24 ` Christoph Hellwig
2018-12-05 9:44 ` Christian Zigotzky
2018-12-05 14:05 ` Christoph Hellwig
2018-12-06 10:55 ` Christian Zigotzky
2018-12-06 17:10 ` Christian Zigotzky
2018-12-06 19:36 ` Christoph Hellwig
2018-12-07 7:48 ` Christian Zigotzky
2018-12-07 13:45 ` Christian Zigotzky
2018-12-07 18:33 ` Christian Zigotzky
2018-12-08 10:29 ` Christian Zigotzky
2018-12-08 13:47 ` Christian Zigotzky
2018-12-09 14:20 ` Christian Zigotzky
2018-12-09 18:26 ` Christian Zigotzky
2018-12-10 15:54 ` Christian Zigotzky
2018-12-11 14:28 ` Christian Zigotzky
2018-12-11 18:17 ` Christian Zigotzky
2018-12-12 0:47 ` Benjamin Herrenschmidt
2018-12-12 7:03 ` Christian Zigotzky
2018-12-12 14:15 ` Christoph Hellwig
2018-12-12 14:39 ` Christian Zigotzky
2018-12-13 8:41 ` Christian Zigotzky
2018-12-13 9:10 ` Christoph Hellwig
2018-12-13 9:47 ` Christian Zigotzky
2018-12-13 11:19 ` Christian Zigotzky
2018-12-13 11:25 ` Christoph Hellwig
2018-12-13 13:34 ` Christian Zigotzky
2018-12-13 17:48 ` Christian Zigotzky
2018-12-13 21:53 ` Christian Zigotzky
2018-12-14 12:00 ` Christian Zigotzky
2018-12-14 16:45 ` Christoph Hellwig
2019-01-03 7:36 ` Christoph Hellwig
2019-01-03 19:26 ` Christian Zigotzky
2019-01-05 16:03 ` Christian Zigotzky
2019-01-09 9:31 ` Christian Zigotzky
2019-01-11 2:10 ` Christian Zigotzky
2019-01-12 18:14 ` Christian Zigotzky
2019-01-15 8:07 ` Christian Zigotzky
2019-01-15 8:49 ` Christian Zigotzky
2019-01-15 10:55 ` Christian Zigotzky
2019-01-15 13:35 ` Christoph Hellwig
2019-01-15 13:56 ` Christian Zigotzky
2019-01-15 15:17 ` Christoph Hellwig
2019-01-17 9:21 ` Christian Zigotzky
2019-01-17 9:31 ` Christoph Hellwig
2019-01-17 9:44 ` Christian Zigotzky
2019-01-18 8:35 ` Christoph Hellwig
2019-01-18 11:10 ` Christian Zigotzky
2019-01-18 11:28 ` Christoph Hellwig
2019-01-18 12:07 ` Christian Zigotzky
2019-01-18 12:18 ` Christoph Hellwig
2019-01-18 12:46 ` Christian Zigotzky
2019-01-18 12:55 ` Christoph Hellwig
2019-01-18 15:06 ` Christian Zigotzky
2019-01-19 11:40 ` Christian Zigotzky
2019-01-19 11:52 ` Christian Zigotzky
2019-01-19 13:02 ` Christoph Hellwig
2019-01-19 14:04 ` Christoph Hellwig
2019-01-21 14:38 ` Christian Zigotzky
2019-01-23 14:34 ` Christian Zigotzky
2019-01-25 13:37 ` Christian Zigotzky
2019-01-27 13:13 ` Christian Zigotzky
2019-01-28 7:04 ` Christoph Hellwig
2019-01-28 16:22 ` Christoph Hellwig
2019-01-28 16:52 ` Christian Zigotzky
2019-01-29 15:03 ` Christian Zigotzky
2019-01-29 16:14 ` Christoph Hellwig
2019-01-29 16:34 ` Christoph Hellwig
2019-01-30 4:40 ` Christian Zigotzky
2019-01-31 12:48 ` Christian Zigotzky
2019-02-01 8:04 ` Christoph Hellwig
2019-02-01 16:54 ` Christian Zigotzky
2019-02-03 16:49 ` Christian Zigotzky
2019-02-04 7:56 ` Christoph Hellwig
2019-02-04 12:13 ` Christian Zigotzky
2019-02-04 12:38 ` Christoph Hellwig
2019-02-06 13:45 ` Christian Zigotzky
2019-02-06 15:15 ` Christoph Hellwig
2019-02-06 15:16 ` Christoph Hellwig
2019-02-07 4:34 ` Christian Zigotzky
2019-02-08 9:01 ` Christian Zigotzky
2019-02-08 9:18 ` Christoph Hellwig
2019-02-08 10:59 ` Christian Zigotzky
2019-02-09 19:26 ` Darren Stevens
2019-02-09 21:10 ` Darren Stevens
2019-02-11 7:41 ` Christoph Hellwig
2019-02-10 12:00 ` Christian Zigotzky [this message]
[not found] ` <0042290A-2939-4EBA-A638-D404FA2055ED@xenosoft.de>
2019-02-11 7:21 ` Christian Zigotzky
2019-02-11 7:38 ` Christoph Hellwig
2019-02-12 12:42 ` Christian Zigotzky
2019-02-12 15:25 ` Christoph Hellwig
2019-02-12 19:31 ` Christian Zigotzky
2019-02-12 19:50 ` Christian Zigotzky
2019-02-12 19:52 ` Christoph Hellwig
[not found] ` <46025f1b-db20-ac23-7dcd-10bc43bbb6ee@xenosoft.de>
[not found] ` <20191105162856.GA15402@lst.de>
2019-11-07 9:53 ` Bug 205201 - overflow of DMA mask and bus mask Christian Zigotzky
2019-11-10 7:27 ` Christian Zigotzky
2019-11-11 8:12 ` Christian Zigotzky
2019-11-11 8:16 ` Christian Zigotzky
2019-11-11 12:22 ` Christian Zigotzky
2019-11-12 14:41 ` Christoph Hellwig
2019-11-12 22:58 ` Christian Zigotzky
2019-11-13 10:14 ` Christian Zigotzky
2019-11-13 11:02 ` Christoph Hellwig
2018-11-29 17:02 ` use generic DMA mapping code in powerpc V4 Christoph Hellwig
2018-12-08 17:03 ` Christoph Hellwig
2018-12-16 16:51 ` Christoph Hellwig
2018-12-17 1:14 ` Michael Ellerman
2018-11-29 19:45 Rui Salvaterra
2018-11-30 10:32 ` Christoph Hellwig
2018-11-30 11:44 ` Rui Salvaterra
2018-11-30 16:41 ` Rui Salvaterra
2018-12-02 6:11 ` Benjamin Herrenschmidt
2018-12-08 17:17 ` Christoph Hellwig
2018-12-10 17:04 ` Rui Salvaterra
2018-12-10 19:33 ` Christoph Hellwig
2018-12-10 20:03 ` Rui Salvaterra
2018-12-10 20:49 ` Benjamin Herrenschmidt
2018-12-11 9:37 ` Rui Salvaterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7137db-e600-0d20-6fb2-6d0f9739aca3@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=runaway@candw.ms \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).