From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-acpi@vger.kernel.org>
Cc: len.brown@intel.com, wency@cn.fujitsu.com, paulus@samba.org,
minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com,
rientjes@google.com, cl@linux.com, akpm@linux-foundation.org,
liuj97@gmail.com
Subject: [RFC PATCH v4 12/13] memory-hotplug : add node_device_release
Date: Wed, 18 Jul 2012 19:17:37 +0900 [thread overview]
Message-ID: <50068D41.9090109@jp.fujitsu.com> (raw)
In-Reply-To: <50068974.1070409@jp.fujitsu.com>
When calling unregister_node(), the function shows following message at
device_release().
Device 'node2' does not have a release() function, it is broken and must be
fixed.
So the patch implements node_device_release()
CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/base/node.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: linux-3.5-rc6/drivers/base/node.c
===================================================================
--- linux-3.5-rc6.orig/drivers/base/node.c 2012-07-18 18:24:29.191121066 +0900
+++ linux-3.5-rc6/drivers/base/node.c 2012-07-18 18:25:47.111146983 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
static inline void hugetlb_unregister_node(struct node *node) {}
#endif
+static void node_device_release(struct device *dev)
+{
+ struct node *node_dev = to_node(dev);
+
+ memset(node_dev, 0, sizeof(struct node));
+}
/*
* register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int
node->dev.id = num;
node->dev.bus = &node_subsys;
+ node->dev.release = node_device_release;
error = device_register(&node->dev);
if (!error){
next prev parent reply other threads:[~2012-07-18 10:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 10:01 [RFC PATCH v4 0/13] memory-hotplug : hot-remove physical memory Yasuaki Ishimatsu
2012-07-18 10:04 ` [RFC PATCH 0/13] firmware_map : unify argument of firmware_map_add_early/hotplug Yasuaki Ishimatsu
2012-07-18 10:05 ` [RFC PATCH v4 1/13] memory-hotplug : rename remove_memory to offline_memory Yasuaki Ishimatsu
2012-07-19 8:19 ` Bob Liu
2012-07-19 9:26 ` Yasuaki Ishimatsu
2012-07-18 10:06 ` [RFC PATCH v4 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove Yasuaki Ishimatsu
2012-07-19 7:23 ` Wen Congyang
2012-07-19 9:32 ` Yasuaki Ishimatsu
2012-07-18 10:07 ` [PATCH v4 3/13] memory-hotplug : check whether memory is present or not Yasuaki Ishimatsu
2012-07-18 10:25 ` Wen Congyang
2012-07-18 10:25 ` Yasuaki Ishimatsu
2012-07-18 10:56 ` Wen Congyang
2012-07-18 10:09 ` [RFC PATCH v4 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs Yasuaki Ishimatsu
2012-07-18 10:33 ` Wen Congyang
2012-07-18 10:51 ` Yasuaki Ishimatsu
2012-07-18 10:10 ` [RFC PATCH v4 5/13] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks Yasuaki Ishimatsu
2012-07-18 10:11 ` [RFC PATCH v4 6/13] memory-hotplug : add memory_block_release Yasuaki Ishimatsu
2012-07-18 10:12 ` [RFC PATCH v4 7/13] memory-hotplug : remove_memory calls __remove_pages Yasuaki Ishimatsu
2012-07-19 8:32 ` Bob Liu
2012-07-19 9:30 ` Yasuaki Ishimatsu
2012-07-18 10:12 ` [RFC PATCH v4 8/13] memory-hotplug : check page type in get_page_bootmem Yasuaki Ishimatsu
2012-07-18 10:14 ` [RFC PATCH v4 9/13] memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap Yasuaki Ishimatsu
2012-07-18 10:16 ` [RFC PATCH v4 11/13] memory-hotplug : free memmap of sparse-vmemmap Yasuaki Ishimatsu
2012-07-19 5:58 ` Wen Congyang
2012-07-19 6:11 ` Yasuaki Ishimatsu
2012-07-19 6:17 ` [RESEND RFC " Yasuaki Ishimatsu
2012-07-19 9:45 ` [RFC " Wen Congyang
2012-07-19 9:54 ` Yasuaki Ishimatsu
2012-07-19 10:01 ` Wen Congyang
2012-07-18 10:17 ` Yasuaki Ishimatsu [this message]
2012-07-27 6:17 ` [RFC PATCH v4 12/13] memory-hotplug : add node_device_release Wen Congyang
2012-07-18 10:18 ` [RFC PATCH v4 13/13] memory-hotplug : remove sysfs file of node Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50068D41.9090109@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).