From: Wen Congyang <wency@cn.fujitsu.com>
To: isimatu.yasuaki@jp.fujitsu.com
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-acpi@vger.kernel.org, len.brown@intel.com,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
cmetcalf@tilera.com, linux-mm@kvack.org, paulus@samba.org,
minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com,
rientjes@google.com, cl@linux.com, linuxppc-dev@lists.ozlabs.org,
akpm@linux-foundation.org, liuj97@gmail.com
Subject: Re: [RFC PATCH V6 13/19] memory-hotplug: check page type in get_page_bootmem
Date: Tue, 07 Aug 2012 13:31:53 +0800 [thread overview]
Message-ID: <5020A849.4050209@cn.fujitsu.com> (raw)
In-Reply-To: <1343980161-14254-14-git-send-email-wency@cn.fujitsu.com>
At 08/03/2012 03:49 PM, wency@cn.fujitsu.com Wrote:
> From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> There is a possibility that get_page_bootmem() is called to the same page many
> times. So when get_page_bootmem is called to the same page, the function only
> increments page->_count.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Jiang Liu <liuj97@gmail.com>
> CC: Len Brown <len.brown@intel.com>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: Paul Mackerras <paulus@samba.org>
> CC: Christoph Lameter <cl@linux.com>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
> mm/memory_hotplug.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 5f9f8c7..710e593 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -95,10 +95,17 @@ static void release_memory_resource(struct resource *res)
> static void get_page_bootmem(unsigned long info, struct page *page,
> unsigned long type)
> {
> - page->lru.next = (struct list_head *) type;
> - SetPagePrivate(page);
> - set_page_private(page, info);
> - atomic_inc(&page->_count);
> + unsigned long page_type;
> +
> + page_type = (unsigned long) page->lru.next;
> + if (type < MEMORY_HOTPLUG_MIN_BOOTMEM_TYPE ||
> + type > MEMORY_HOTPLUG_MAX_BOOTMEM_TYPE){
I think it should be page_type not type here.
Thanks
Wen Congyang
> + page->lru.next = (struct list_head *) type;
> + SetPagePrivate(page);
> + set_page_private(page, info);
> + atomic_inc(&page->_count);
> + } else
> + atomic_inc(&page->_count);
> }
>
> /* reference to __meminit __free_pages_bootmem is valid
next prev parent reply other threads:[~2012-08-07 5:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 7:49 [RFC PATCH V6 00/19] memory-hotplug: hot-remove physical memory wency
2012-08-03 7:49 ` [RFC PATCH V6 01/19] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages() wency
2012-08-03 7:49 ` [RFC PATCH V6 02/19] memory-hotplug: implement offline_memory() wency
2012-08-03 7:49 ` [RFC PATCH V6 03/19] memory-hotplug: store the node id in acpi_memory_device wency
2012-08-03 7:49 ` [RFC PATCH V6 04/19] memory-hotplug: offline and remove memory when removing the memory device wency
2012-08-09 15:41 ` Vasilis Liaskovitis
2012-08-03 7:49 ` [RFC PATCH V6 05/19] memory-hotplug: check whether memory is present or not wency
2012-08-03 7:49 ` [RFC PATCH V6 06/19] memory-hotplug: export the function acpi_bus_remove() wency
2012-08-03 7:49 ` [RFC PATCH V6 07/19] memory-hotplug: call acpi_bus_remove() to remove memory device wency
2012-08-03 7:49 ` [RFC PATCH V6 08/19] memory-hotplug: remove /sys/firmware/memmap/X sysfs wency
2012-08-03 7:49 ` [RFC PATCH V6 09/19] memory-hotplug: does not release memory region in PAGES_PER_SECTION chunks wency
2012-08-03 7:49 ` [RFC PATCH V6 10/19] memory-hotplug: add memory_block_release wency
2012-09-06 7:06 ` wujianguo
2012-08-03 7:49 ` [RFC PATCH V6 11/19] memory-hotplug: remove_memory calls __remove_pages wency
2012-08-03 7:49 ` [RFC PATCH V6 12/19] memory-hotplug: introduce new function arch_remove_memory() wency
2012-08-03 7:49 ` [RFC PATCH V6 13/19] memory-hotplug: check page type in get_page_bootmem wency
2012-08-07 5:31 ` Wen Congyang [this message]
2012-08-03 7:49 ` [RFC PATCH V6 14/19] memory-hotplug: move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap wency
2012-08-03 7:49 ` [RFC PATCH V6 15/19] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap wency
2012-08-07 3:48 ` Wen Congyang
2012-08-03 7:49 ` [RFC PATCH V6 16/19] memory-hotplug: free memmap " wency
2012-08-07 5:17 ` Wen Congyang
2012-08-03 7:49 ` [RFC PATCH V6 17/19] memory_hotplug: clear zone when the memory is removed wency
2012-08-03 7:49 ` [RFC PATCH V6 18/19] memory-hotplug: add node_device_release wency
2012-08-03 7:49 ` [RFC PATCH V6 19/19] memory-hotplug: remove sysfs file of node wency
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020A849.4050209@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).