From: Scott Wood <scottwood@freescale.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Chang-Ming.Huang@freescale.com, linux-mmc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
Date: Tue, 11 Sep 2012 13:28:17 -0500 [thread overview]
Message-ID: <504F82C1.2000907@freescale.com> (raw)
In-Reply-To: <20120911080457.GA28235@lizard>
On 09/11/2012 03:04 AM, Anton Vorontsov wrote:
> On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote:
>> On Tue, Sep 11, 2012 at 03:12:44PM +0800, Chang-Ming.Huang@freescale.com wrote:
>>> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>>>
>>> Below SOCs don't support the cmd23 command for MMC card,
>>> therefore, disable it in device tree:
>>> P1020, P1021, P1022, P1024, P1025 and P4080
>>>
>>> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
>>
>> Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
>
> Btw, although the patch is trivial, I guess you still want to let know
> PowerPC folks about it. Adding Cc and copying the patch:
>
> - - - -
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>
> Below SOCs don't support the cmd23 command for MMC card,
> therefore, disable it in device tree:
> P1020, P1021, P1022, P1024, P1025 and P4080
>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> CC: Anton Vorontsov <cbouatmailru@gmail.com>
> ---
> arch/powerpc/boot/dts/fsl/p1020si-post.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/p1021si-post.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> index 68cc5e7..793a30b 100644
> --- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> @@ -154,6 +154,7 @@
> sdhc@2e000 {
> compatible = "fsl,p1020-esdhc", "fsl,esdhc";
> sdhci,auto-cmd12;
> + sdhci,no-cmd23;
> };
> /include/ "pq3-sec3.3-0.dtsi"
>
> diff --git a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi
> index adb82fd..2b7fd2a 100644
> --- a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi
> @@ -149,6 +149,7 @@
> /include/ "pq3-esdhc-0.dtsi"
> sdhc@2e000 {
> sdhci,auto-cmd12;
> + sdhci,no-cmd23;
> };
>
> /include/ "pq3-sec3.3-0.dtsi"
> diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
> index 06216b8..2334a52 100644
> --- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
> @@ -215,6 +215,7 @@
> sdhc@2e000 {
> compatible = "fsl,p1022-esdhc", "fsl,esdhc";
> sdhci,auto-cmd12;
> + sdhci,no-cmd23;
> };
>
> /include/ "pq3-sec3.3-0.dtsi"
> diff --git a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi
> index 8d35d2c..5b39952 100644
> --- a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi
> @@ -337,6 +337,7 @@
> sdhc@114000 {
> voltage-ranges = <3300 3300>;
> sdhci,auto-cmd12;
> + sdhci,no-cmd23;
> };
>
> /include/ "qoriq-i2c-0.dtsi"
>
This won't help people with old device trees (forked for a custom board,
tied to an old U-Boot, etc). The driver should infer this from the
compatible string or version registers (ideally block-specific version
registers, but if these are absent or inconclusive, SVR can be used).
-Scott
next prev parent reply other threads:[~2012-09-11 18:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347347565-17474-1-git-send-email-Chang-Ming.Huang@freescale.com>
[not found] ` <1347347565-17474-2-git-send-email-Chang-Ming.Huang@freescale.com>
[not found] ` <20120911075429.GA27028@lizard>
2012-09-11 8:04 ` [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Anton Vorontsov
2012-09-11 9:36 ` Huang Changming-R66093
2012-09-11 12:43 ` Kumar Gala
2012-09-11 12:49 ` Kumar Gala
2012-09-11 14:44 ` Chris Ball
2012-09-11 20:26 ` Kumar Gala
2012-09-11 20:59 ` Chris Ball
2012-09-12 6:18 ` Huang Changming-R66093
2012-09-12 12:13 ` Kumar Gala
2012-09-13 2:02 ` Huang Changming-R66093
2012-09-13 12:47 ` Kumar Gala
2012-09-14 2:02 ` Huang Changming-R66093
2012-09-14 12:40 ` Kumar Gala
2012-09-17 12:36 ` Chris Ball
2012-09-17 13:12 ` Kumar Gala
2012-09-17 13:45 ` Chris Ball
2012-09-18 1:09 ` Huang Changming-R66093
2012-09-18 5:00 ` Kumar Gala
2012-09-18 5:07 ` Chris Ball
2012-09-11 18:28 ` Scott Wood [this message]
2012-09-12 3:19 ` Huang Changming-R66093
2012-09-12 3:38 ` Anton Vorontsov
2012-09-13 7:57 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F82C1.2000907@freescale.com \
--to=scottwood@freescale.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).