From: kishon <kishon@ti.com>
To: Vivek Gautam <gautamvivek1987@gmail.com>
Cc: linux-doc@vger.kernel.org, tony@atomide.com,
linux@arm.linux.org.uk, linux-sh@vger.kernel.org,
alexander.shishkin@linux.intel.com, stern@rowland.harvard.edu,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, rob.herring@calxeda.com,
horms@verge.net.au, haojian.zhuang@gmail.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
eric.y.miao@gmail.com, b-cousson@ti.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, cbou@mail.ru,
rob@landley.net, dwmw2@infradead.org
Subject: Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information
Date: Thu, 17 Jan 2013 18:01:31 +0530 [thread overview]
Message-ID: <50F7EF23.8080903@ti.com> (raw)
In-Reply-To: <CAFp+6iGEC9KgfuQz6nqnAY5JrmtPG=HkGw5yjKw7-1=8AG_=dg@mail.gmail.com>
Hi,
On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote:
> Hi Kishon,
>
>
> On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> This is in preparation for the changes in PHY library to support adding
>> and getting multiple PHYs of the same type. In the new design, the
>> binding information between the PHY and the USB controller should be
>> specified in the platform specific initialization code. So it's been
>> done for OMAP platforms here.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> This kind-of binding should be done in all the platforms (I've done only
>> for OMAP platform).
>> arch/arm/mach-omap2/usb-musb.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
>> index 9d27e3f..bbe2fa5 100644
>> --- a/arch/arm/mach-omap2/usb-musb.c
>> +++ b/arch/arm/mach-omap2/usb-musb.c
>> @@ -24,6 +24,7 @@
>> #include <linux/dma-mapping.h>
>> #include <linux/io.h>
>> #include <linux/usb/musb.h>
>> +#include <linux/usb/phy.h>
>>
>> #include "omap_device.h"
>> #include "soc.h"
>> @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
>> musb_plat.mode = board_data->mode;
>> musb_plat.extvbus = board_data->extvbus;
>>
>> - if (cpu_is_omap44xx())
>> + if (cpu_is_omap44xx()) {
>> musb_plat.has_mailbox = true;
>> + usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
>> + } else if (cpu_is_omap34xx()) {
>> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> + }
>
> Just trying to understand things here.
> Is the device name we are using here the platform device name (pdev->name) ?
it's pdev->dev.name.
> If i am not wrong then for devices added through device tree
> the device name would actually include the device address in the string,
Ideally for device tree, devm_usb_get_phy_by_phandle() introduced in the
5th patch of this series should be used.
usb_bind_phy should be called from platform specific initialization
files (like your board file), which won't get executed in dt boot.
> wouldn't that make things somewhat weird, since we will have to add
> such bindings
> using this address string.
>
> one more doubt please :)
> is it possible to bind phy in the controllers' driver somehow ?
Thats not going to be good. Why do you need to do that?
Thanks
Kishon
next prev parent reply other threads:[~2013-01-17 12:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 15:00 [RFC PATCH 0/6] USB: Add multiple PHYs of same type Kishon Vijay Abraham I
2013-01-16 15:00 ` [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY Kishon Vijay Abraham I
2013-01-17 9:37 ` Roger Quadros
2013-01-17 11:14 ` kishon
2013-01-18 11:48 ` Felipe Balbi
2013-01-16 15:00 ` [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-01-17 9:39 ` Roger Quadros
2013-01-17 11:03 ` kishon
2013-01-17 12:11 ` Vivek Gautam
2013-01-17 12:31 ` kishon [this message]
2013-01-17 13:11 ` Vivek Gautam
2013-01-16 15:00 ` [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type Kishon Vijay Abraham I
2013-01-17 0:31 ` Simon Horman
2013-01-17 16:07 ` Roger Quadros
2013-01-18 5:28 ` kishon
2013-01-16 15:01 ` [RFC PATCH 4/6] ARM: dts: OMAP: Add phandle to bind PHY with USB controller Kishon Vijay Abraham I
2013-01-16 15:01 ` [RFC PATCH 5/6] usb: otg: add device tree support to otg library Kishon Vijay Abraham I
2013-01-21 13:21 ` Roger Quadros
2013-01-21 13:34 ` kishon
2013-01-21 14:23 ` Roger Quadros
2013-01-16 15:01 ` [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot Kishon Vijay Abraham I
2013-01-21 13:18 ` Roger Quadros
2013-01-21 13:41 ` kishon
2013-01-21 14:24 ` Roger Quadros
2013-01-18 11:48 ` [RFC PATCH 0/6] USB: Add multiple PHYs of same type Felipe Balbi
2013-01-18 11:54 ` kishon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F7EF23.8080903@ti.com \
--to=kishon@ti.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=cbou@mail.ru \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=eric.y.miao@gmail.com \
--cc=gautamvivek1987@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).