From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Wang Wenhu <wenhu.wang@vivo.com>, kernel@vivo.com
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Scott Wood <oss@buserror.net>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr
Date: Tue, 15 Mar 2022 13:45:30 +0100 [thread overview]
Message-ID: <50ec8577-23a5-cbba-f8d4-a3ca37439298@csgroup.eu> (raw)
In-Reply-To: <20200424085839.60284-2-wenhu.wang@vivo.com>
Le 24/04/2020 à 10:58, Wang Wenhu a écrit :
> Include "linux/of_address.h" to fix the compile error for
> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
>
> CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’:
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration]
> l2ctlr = of_iomap(dev->dev.of_node, 0);
> ^~~~~~~~
> pci_iomap
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> l2ctlr = of_iomap(dev->dev.of_node, 0);
> ^
> cc1: all warnings being treated as errors
> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Scott Wood <oss@buserror.net>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
Is there still an interest for this series ?
I see there is even a v5 at
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421&state=*
allthough I can't find it in my emails.
If so do you plan to send any update of it at some point ?
Otherwise, as CONFIG_FSL_85XX_CACHE_SRAM is not user selectable and no
driver selects it, I think time has come to remove it completely.
Thanks
Christophe
> ---
> No change v1-v4
> ---
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> index 2d0af0c517bb..7533572492f0 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of_platform.h>
> +#include <linux/of_address.h>
> #include <asm/io.h>
>
> #include "fsl_85xx_cache_ctlr.h"
next prev parent reply other threads:[~2022-03-15 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200424085839.60284-1-wenhu.wang@vivo.com>
2020-04-24 8:58 ` [PATCH v4, 1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr Wang Wenhu
2022-03-15 12:45 ` Christophe Leroy [this message]
2022-05-28 7:03 ` [PATCH v4,1/5] " Christophe Leroy
2020-04-24 8:58 ` [PATCH v4, 2/5] powerpc: sysdev: fix compile error for fsl_85xx_cache_sram Wang Wenhu
2020-04-24 8:58 ` [PATCH v4, 3/5] powerpc: sysdev: fix compile warning " Wang Wenhu
2020-04-24 8:58 ` [PATCH v4,4/5] misc: sram_dynamic for user level SRAM access Wang Wenhu
2020-04-24 8:58 ` [PATCH v4, 5/5] powerpc: sysdev: support userspace access of fsl_85xx_sram Wang Wenhu
2022-06-08 5:44 [PATCH v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr wenhu wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ec8577-23a5-cbba-f8d4-a3ca37439298@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@vivo.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=rdunlap@infradead.org \
--cc=wenhu.wang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).