From: Michael Neuling <mikey@neuling.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: paulus@samba.org, Anton Blanchard <anton@samba.org>,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: POWER7 optimised copy_to_user/copy_from_user using VMX
Date: Thu, 08 Dec 2011 16:54:09 +1100 [thread overview]
Message-ID: <5188.1323323649@neuling.org> (raw)
In-Reply-To: <FC884692-A7C3-47F6-BDD5-9E3D955ABF9B@kernel.crashing.org>
<snip>
> > +#define CPU_FTR_POWER7 = LONG_ASM_CONST(0x2000000000000000)
<snip>
> Can we find a means to do the fixup that does NOT require a FTR bit? I
> have the feeling FSL will want to have various optimized copy functions
> for our different cores and I hate to blow features bits just for this.
+1
I hate the idea of having a POWER7 FTR bit. Every loon will (and has
tried to in the past) attach every POWER7 related thing to it, rather
than thinking about what the feature really is for.
What about other processors which could also benefit from this copy
loop? Turning on CPU_FTR_POWER7 for them is gonna look a bit silly.
Mikey
next prev parent reply other threads:[~2011-12-08 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 5:02 [PATCH] powerpc: POWER7 optimised copy_to_user/copy_from_user using VMX Anton Blanchard
2011-12-08 5:44 ` Kumar Gala
2011-12-08 5:54 ` Michael Neuling [this message]
2011-12-08 6:04 ` Anton Blanchard
2011-12-08 13:31 ` Segher Boessenkool
2011-12-08 14:02 ` David Laight
2011-12-08 14:12 ` Segher Boessenkool
2011-12-08 19:40 ` Benjamin Herrenschmidt
2011-12-08 6:11 ` Anton Blanchard
2011-12-19 3:00 ` Benjamin Herrenschmidt
2011-12-19 3:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188.1323323649@neuling.org \
--to=mikey@neuling.org \
--cc=anton@samba.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).