From: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: jkenisto@linux.vnet.ibm.com, tony.luck@intel.com,
keescook@chromium.org, mahesh@linux.vnet.ibm.com,
ccross@android.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
cbouatmailru@gmail.com
Subject: Re: [PATCH v4 0/8] Nvram-to-pstore
Date: Wed, 19 Jun 2013 12:04:00 +0530 [thread overview]
Message-ID: <51C150D8.2070706@linux.vnet.ibm.com> (raw)
In-Reply-To: <1822.1371622503@ale.ozlabs.ibm.com>
Hi Michael,
On Wednesday 19 June 2013 11:45 AM, Michael Neuling wrote:
> Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com> wrote:
>> Currently the kernel provides the contents of p-series NVRAM only as a
>> simple stream of bytes via /dev/nvram, which must be interpreted in user
>> space by the nvram command in the powerpc-utils package. This patch set
>> exploits the pstore subsystem to expose each partition in NVRAM as a
>> separate file in /dev/pstore. For instance, Oops messages will be stored
>> in a file named [dmesg-nvram-2].
>>
>> Changes from v3:
>> - Change filename prefix for of-config and common partition
>>
>> Changes from v2:
>> - Fix renaming of pstore type ids in nvram.c
>>
>> Changes from v1:
>> - Reduce #ifdefs by and remove forward declarations of pstore callbacks
>> - Handle return value of nvram_write_os_partition
>> - Remove empty pstore callbacks and register pstore only when pstore
>> is configured
> When booted on pHyp, I see /dev/nvram but not /dev/pstore, even if I
> turn on CONFIG_PSTORE. Is there something else I need to add?
You need to mount pstore to access the files.
# mkdir /dev/pstore
# mount -t pstore - /dev/pstore
to unmount
# umount /dev/pstore
References: http://lwn.net/Articles/421297/
Documentation/ABI/testing/pstore
>
> Should we update pseries_defconfig to include CONFIG_PSTORE (which it
> doesn't include currently)? Maybe turn on panic/oops via
> CONFIG_PSTORE_RAM too?
Yes. We should enable CONFIG_PSTORE by default in pseries_defconfig.
We need not enable CONFIG_PSTORE_RAM for our case. Its for systems with
persistent RAM.
> Other than that, the series looks clean. It's passes my build and boot
> tests.
>
> I've not reviewed the contents of the patches.
>
> Mikey
>
>> ---
>>
>> Aruna Balakrishnaiah (8):
>> powerpc/pseries: Remove syslog prefix in uncompressed oops text
>> powerpc/pseries: Add version and timestamp to oops header
>> powerpc/pseries: Introduce generic read function to read nvram-partitions
>> powerpc/pseries: Read/Write oops nvram partition via pstore
>> powerpc/pseries: Read rtas partition via pstore
>> powerpc/pseries: Distinguish between a os-partition and non-os partition
>> powerpc/pseries: Read of-config partition via pstore
>> powerpc/pseries: Read common partition via pstore
>>
>>
>> arch/powerpc/platforms/pseries/nvram.c | 353 +++++++++++++++++++++++++++-----
>> fs/pstore/inode.c | 9 +
>> include/linux/pstore.h | 4
>> 3 files changed, 313 insertions(+), 53 deletions(-)
>>
>> --
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
>>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2013-06-19 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 18:50 [PATCH v4 0/8] Nvram-to-pstore Aruna Balakrishnaiah
2013-06-05 18:50 ` [PATCH v4 1/8] powerpc/pseries: Remove syslog prefix in uncompressed oops text Aruna Balakrishnaiah
2013-06-05 18:51 ` [PATCH v4 2/8] powerpc/pseries: Add version and timestamp to oops header Aruna Balakrishnaiah
2013-06-05 18:51 ` [PATCH v4 3/8] powerpc/pseries: Introduce generic read function to read nvram-partitions Aruna Balakrishnaiah
2013-06-05 18:51 ` [PATCH v4 4/8] powerpc/pseries: Read/Write oops nvram partition via pstore Aruna Balakrishnaiah
2013-06-05 18:51 ` [PATCH v4 5/8] powerpc/pseries: Read rtas " Aruna Balakrishnaiah
2013-06-05 18:51 ` [PATCH v4 6/8] powerpc/pseries: Distinguish between a os-partition and non-os partition Aruna Balakrishnaiah
2013-06-05 18:52 ` [PATCH v4 7/8] powerpc/pseries: Read of-config partition via pstore Aruna Balakrishnaiah
2013-06-05 18:52 ` [PATCH v4 8/8] powerpc/pseries: Read common " Aruna Balakrishnaiah
2013-06-19 6:15 ` [PATCH v4 0/8] Nvram-to-pstore Michael Neuling
2013-06-19 6:34 ` Aruna Balakrishnaiah [this message]
2013-06-19 6:38 ` Michael Neuling
2013-06-19 18:46 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C150D8.2070706@linux.vnet.ibm.com \
--to=aruna@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).