From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, Zhao Chenhui <chenhui.zhao@freescale.com>
Subject: Re: [PATCH 1/7] powerpc/85xx: re-enable timebase sync disabled by KEXEC patch
Date: Fri, 4 Nov 2011 14:33:58 -0500 [thread overview]
Message-ID: <51CCC521-0A2C-4940-98F0-BA0075D6F122@kernel.crashing.org> (raw)
In-Reply-To: <4EB421FD.6010805@freescale.com>
On Nov 4, 2011, at 12:33 PM, Scott Wood wrote:
> On 11/04/2011 07:29 AM, Zhao Chenhui wrote:
>> From: Li Yang <leoli@freescale.com>
>>
>> The timebase sync is not only necessary when using KEXEC. It should also
>> be used by normal boot up and cpu hotplug. Remove the ifdef added by
>> the KEXEC patch.
>
> The KEXEC patch didn't just add the ifdef, it also added the initializers:
>
>> @@ -105,8 +107,64 @@ smp_85xx_setup_cpu(int cpu_nr)
>>
>> struct smp_ops_t smp_85xx_ops = {
>> .kick_cpu = smp_85xx_kick_cpu,
>> +#ifdef CONFIG_KEXEC
>> + .give_timebase = smp_generic_give_timebase,
>> + .take_timebase = smp_generic_take_timebase,
>> +#endif
>> };
>
> U-Boot synchronizes the timebase on 85xx. With what chip and U-Boot
> version are you seeing this not happen?
>
> If you are seeing only a small (around one tick) difference, make sure
> you're running a U-Boot that has this commit:
>
>> commit 7afc45ad7d9493208d89072cbb78a5bfc8034b59
>> Author: Kumar Gala <galak@kernel.crashing.org>
>> Date: Sun Mar 13 10:55:53 2011 -0500
>>
>> powerpc/85xx: Fix synchronization of timebase on MP boot
>>
>> There is a small ordering issue in the master core in that we need to
>> make sure the disabling of the timebase in the SoC is visible before we
>> set the value to 0. We can simply just read back the value to
>> synchronizatize the write, before we set TB to 0.
>>
>> Reported-by: Dan Hettena
>> Tested-by: Dan Hettena
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Scott,
Aren't we going to need this when a core is woken back up w/o any state?
- k
next prev parent reply other threads:[~2011-11-04 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:29 [PATCH 1/7] powerpc/85xx: re-enable timebase sync disabled by KEXEC patch Zhao Chenhui
2011-11-04 17:33 ` Scott Wood
2011-11-04 19:33 ` Kumar Gala [this message]
2011-11-04 19:38 ` Scott Wood
2011-11-08 9:06 ` Li Yang-R58472
2011-11-08 17:28 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2010-12-03 12:34 Li Yang
2010-12-03 16:40 ` Kumar Gala
2010-12-03 18:27 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CCC521-0A2C-4940-98F0-BA0075D6F122@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=chenhui.zhao@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).