From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Dmitry Safonov <dima@arista.com>, linux-kernel@vger.kernel.org
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-aspeed@lists.ozlabs.org,
"Dmitry Safonov" <0x7f454c46@gmail.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Paul Mackerras" <paulus@samba.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
sparclinux@vger.kernel.org, "Fabio Estevam" <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Vasiliy Khoruzhick" <vasilykh@arista.com>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Kevin Hilman" <khilman@baylibre.com>,
"Russell King" <linux@armlinux.org.uk>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Andy Gross" <agross@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Joel Stanley" <joel@jms.id.au>,
linux-serial@vger.kernel.org, "Jiri Slaby" <jslaby@suse.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Iurii Zaikin" <yzaikin@google.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Kees Cook" <keescook@chromium.org>,
linux-arm-msm@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Baolin Wang" <baolin.wang7@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-amlogic@lists.infradead.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Timur Tabi" <timur@kernel.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org,
"Patrice Chotard" <patrice.chotard@st.com>,
"Tony Prisk" <linux@prisktech.co.nz>,
"Richard Genoud" <richard.genoud@gmail.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Vineet Gupta" <vgupta@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
linux-fsdevel@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/58] serial/sysrq: Cleanup ifdeffery
Date: Fri, 13 Dec 2019 06:47:58 +0100 [thread overview]
Message-ID: <524d9848-28a5-7e65-699b-600c49606487@c-s.fr> (raw)
In-Reply-To: <20191213000657.931618-1-dima@arista.com>
Le 13/12/2019 à 01:05, Dmitry Safonov a écrit :
> The original purpose of the patches set was to add a way to enable
> sysrq on a uart where currently it can be constantly either on or off
> (CONFIG_MAGIC_SYSRQ_SERIAL), see the last patch:
> "serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE"
>
> But to do that, I had to add uart_try_toggle_sysrq() and I didn't want
> to bloat serial_core.h even more. So, I did cleanup by removing
> SUPPORT_SYSRQ resulting in a nice diff-stat and lesser ifdeffery.
>
> Most patches are one-liners, I decided to keep them separated per-driver
> to let reviewers easier follow the purpose.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Vasiliy Khoruzhick <vasilykh@arista.com>
> Cc: linux-serial@vger.kernel.org
>
> Dmitry Safonov (58):
> sysrq: Remove sysrq_handler_registered
> serial: Move sysrq members above
> serial_core: Un-ifdef sysrq SUPPORT_SYSRQ
> tty/serial: Migrate aspeed_vuart to use has_sysrq
> tty/serial: Migrate 8250_fsl to use has_sysrq
> tty/serial: Migrate bcm63xx_uart to use has_sysrq
> tty/serial: Migrate 8250_omap to use has_sysrq
> tty/serial: Migrate 8250_port to use has_sysrq
> tty/serial: Migrate amba-pl01* to use has_sysrq
> tty/serial: Migrate apbuart to use has_sysrq
> tty/serial: Migrate arc_uart to use has_sysrq
> tty/serial: Migrate atmel_serial to use has_sysrq
> tty/serial: Migrate clps711x to use has_sysrq
> tty/serial: Migrate cpm_uart to use has_sysrq
> tty/serial: Migrate dz to use has_sysrq
> tty/serial: Migrate efm32-uart to use has_sysrq
> tty/serial: Migrate fsl_linflexuart to use has_sysrq
> tty/serial: Migrate fsl_lpuart to use has_sysrq
> tty/serial: Migrate imx to use has_sysrq
> tty/serial: Migrate ip22zilog to use has_sysrq
> tty/serial: Migrate meson_uart to use has_sysrq
> tty/serial: Migrate milbeaut_usio to use has_sysrq
> tty/serial: Migrate mpc52xx_uart to use has_sysrq
> tty/serial: Don't zero port->sysrq
> tty/serial: Migrate msm_serial to use has_sysrq
> tty/serial: Migrate mux to use has_sysrq
> tty/serial: Migrate mxs-auart to use has_sysrq
> tty/serial: Migrate omap-serial to use has_sysrq
> tty/serial: Migrate pch_uart to use has_sysrq
> tty/serial: Don't check port->sysrq
> tty/serial: Migrate pmac_zilog to use has_sysrq
> tty/serial: Migrate pnx8xxx_uart to use has_sysrq
> serial/f81534: Don't check port->sysrq
> tty/serial: Migrate pxa to use has_sysrq
> tty/serial: Migrate qcom_geni_serial to use has_sysrq
> tty/serial: Migrate sa1100 to use has_sysrq
> tty/serial: Migrate samsung_tty to use has_sysrq
> tty/serial: Migrate sb1250-duart to use has_sysrq
> tty/serial: Migrate sccnxp to use has_sysrq
> tty/serial: Migrate serial_txx9 to use has_sysrq
> tty/serial: Migrate sh-sci to use has_sysrq
> tty/serial: Migrate sprd_serial to use has_sysrq
> tty/serial: Migrate st-asc to use has_sysrq
> tty/serial: Migrate stm32-usart to use has_sysrq
> tty/serial: Migrate sunhv to use has_sysrq
> tty/serial: Migrate sunsab to use has_sysrq
> tty/serial: Migrate sunsu to use has_sysrq
> tty/serial: Migrate sunzilog to use has_sysrq
> serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ
> tty/serial: Migrate vr41xx_siu to use has_sysrq
> tty/serial: Migrate vt8500_serial to use has_sysrq
> tty/serial: Migrate xilinx_uartps to use has_sysrq
> tty/serial: Migrate zs to use has_sysrq
> serial_core: Remove SUPPORT_SYSRQ ifdeffery
> usb/serial: Don't handle break when CONFIG_MAGIC_SYSRQ is disabled
> serial_core: Move sysrq functions from header file
> sysctl/sysrq: Remove __sysrq_enabled copy
> serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
powerpc patchwork didn't get the full series, see
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=148198
Can't find them on linux-serial patchwork either
(https://patches.linaro.org/project/linux-serial/list/)
It is impossible to review/test powerpc bits without the first patches
of the series, where can the entire series be found ?
Christophe
>
> arch/powerpc/kernel/legacy_serial.c | 4 +-
> drivers/tty/serial/8250/8250_aspeed_vuart.c | 5 +-
> drivers/tty/serial/8250/8250_fsl.c | 4 -
> drivers/tty/serial/8250/8250_of.c | 4 +-
> drivers/tty/serial/8250/8250_omap.c | 5 +-
> drivers/tty/serial/8250/8250_port.c | 5 +-
> drivers/tty/serial/amba-pl010.c | 5 +-
> drivers/tty/serial/amba-pl011.c | 6 +-
> drivers/tty/serial/apbuart.c | 5 +-
> drivers/tty/serial/arc_uart.c | 5 +-
> drivers/tty/serial/atmel_serial.c | 9 +-
> drivers/tty/serial/bcm63xx_uart.c | 5 +-
> drivers/tty/serial/clps711x.c | 5 +-
> drivers/tty/serial/cpm_uart/cpm_uart_core.c | 9 +-
> drivers/tty/serial/dz.c | 5 +-
> drivers/tty/serial/efm32-uart.c | 5 +-
> drivers/tty/serial/fsl_linflexuart.c | 8 +-
> drivers/tty/serial/fsl_lpuart.c | 9 +-
> drivers/tty/serial/imx.c | 7 +-
> drivers/tty/serial/ip22zilog.c | 7 +-
> drivers/tty/serial/meson_uart.c | 5 +-
> drivers/tty/serial/milbeaut_usio.c | 5 +-
> drivers/tty/serial/mpc52xx_uart.c | 11 +-
> drivers/tty/serial/msm_serial.c | 5 +-
> drivers/tty/serial/mux.c | 5 +-
> drivers/tty/serial/mxs-auart.c | 5 +-
> drivers/tty/serial/omap-serial.c | 5 +-
> drivers/tty/serial/pch_uart.c | 12 +-
> drivers/tty/serial/pmac_zilog.c | 5 +-
> drivers/tty/serial/pnx8xxx_uart.c | 7 +-
> drivers/tty/serial/pxa.c | 5 +-
> drivers/tty/serial/qcom_geni_serial.c | 5 +-
> drivers/tty/serial/sa1100.c | 7 +-
> drivers/tty/serial/samsung_tty.c | 5 +-
> drivers/tty/serial/sb1250-duart.c | 5 +-
> drivers/tty/serial/sccnxp.c | 5 +-
> drivers/tty/serial/serial_core.c | 123 ++++++++++++++++++++
> drivers/tty/serial/serial_txx9.c | 5 +-
> drivers/tty/serial/sh-sci.c | 10 +-
> drivers/tty/serial/sprd_serial.c | 5 +-
> drivers/tty/serial/st-asc.c | 5 +-
> drivers/tty/serial/stm32-usart.c | 5 +-
> drivers/tty/serial/sunhv.c | 5 +-
> drivers/tty/serial/sunsab.c | 5 +-
> drivers/tty/serial/sunsu.c | 5 +-
> drivers/tty/serial/sunzilog.c | 6 +-
> drivers/tty/serial/ucc_uart.c | 2 -
> drivers/tty/serial/vr41xx_siu.c | 5 +-
> drivers/tty/serial/vt8500_serial.c | 5 +-
> drivers/tty/serial/xilinx_uartps.c | 5 +-
> drivers/tty/serial/zs.c | 5 +-
> drivers/tty/sysrq.c | 16 +--
> drivers/usb/serial/f81534.c | 6 +-
> drivers/usb/serial/generic.c | 10 +-
> include/linux/serial_core.h | 92 ++-------------
> include/linux/sysrq.h | 1 +
> kernel/sysctl.c | 41 ++++---
> lib/Kconfig.debug | 8 ++
> 58 files changed, 238 insertions(+), 346 deletions(-)
>
next prev parent reply other threads:[~2019-12-13 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
2019-12-13 0:06 ` [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq Dmitry Safonov
2019-12-13 0:06 ` [PATCH 31/58] tty/serial: Migrate pmac_zilog " Dmitry Safonov
2019-12-13 0:06 ` [PATCH 49/58] serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ Dmitry Safonov
2019-12-13 5:47 ` Christophe Leroy [this message]
2019-12-13 16:41 ` [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524d9848-28a5-7e65-699b-600c49606487@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=0x7f454c46@gmail.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@aj.id.au \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=linux@prisktech.co.nz \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ludovic.desroches@microchip.com \
--cc=macro@linux-mips.org \
--cc=mcgrof@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@st.com \
--cc=paulus@samba.org \
--cc=richard.genoud@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=sparclinux@vger.kernel.org \
--cc=timur@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vasilykh@arista.com \
--cc=vgupta@synopsys.com \
--cc=yzaikin@google.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).