From: Philippe Bergheaud <felix@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: set default kernel thread priority to medium-low
Date: Thu, 12 Dec 2013 08:11:28 +0100 [thread overview]
Message-ID: <52A961A0.5010307@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386811338.12662.3.camel@concordia>
Michael Ellerman wrote:
> On Wed, 2013-12-11 at 11:30 +0100, Philippe Bergheaud wrote:
>
>>Benjamin Herrenschmidt wrote:
>>
>>>On Wed, 2013-12-11 at 17:29 +1100, Michael Ellerman wrote:
>>>
>>>
>>>
>>>>It would be nice if you could make an assertion about what the state of HMT
>>>>handling should be once your patch is applied.
>>>>
>>>>I think it's:
>>>>
>>>>* The kernel should use HMT_MEDIUM_LOW as it's "default" priority
>>>>* The kernel should use HMT_LOW as it's "low" priority
>>>>
>>>>Which would imply:
>>>>
>>>>* The kernel should not use HMT_MEDIUM anywhere ..
>>>>* Nor should it use any of the other higher HMT modes.
>>>>
>>>>Do you agree?
>
>
>>Not entirely. HT_MEDIUM might still be used by the kernel, in places where a
>>priority higher than the default is required.
>
>
> Right. But any code that currently uses HMT_MEDIUM is at the default level,
> whereas once your patch is applied any code still using HMT_MEDIUM will be
> boosted vs the default.
>
> So any code that still uses HMT_MEDIUM after your patch seems like a bug to me.
>
>
>>>>The reason I ask is I still see HMT_MEDIUM used in a few places, and it's not
>>>>clear to me if that is correct.
>>>
>>>
>>>HMT_MEDIUM used to be our default no ?
>
>
>>Yes, but I am not sure that all references to HMT_MEDIUM were references to
>>the default kernel priority.
>
>
> What were they references to? Regardless they will now have the effect of
> boosting the priority in those code sections. It would be good to understand,
> and document, any places where we still use HMT_MEDIUM and why.
Yes. This needs to be documented.
>
>>>Also there's an open question... when doing things with interrupts off
>>>(or worse, in real mode) such as some KVM hcalls etc... should we on the
>>>contrary boost up to limit interrupt latency ?
>
>
>>Yes. I think that there are cases when one should consider using HT_MEDIUM.
>
>
> Or HIGH?
Correct, I had not thought of that option.
> But let's not get side-tracked on that until we've got the default sorted.
>
>
>>Shouldn't we define a new macro HMT_DEFAULT, to identify explicitely where
>>the default priority is required?
>
>
> That might help clarify things yes.
>
> cheers
>
Thank you for the help. I will rework this.
Philippe
next prev parent reply other threads:[~2013-12-12 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 7:39 [PATCH] powerpc: set default kernel thread priority to medium-low Philippe Bergheaud
2013-12-11 6:29 ` Michael Ellerman
2013-12-11 9:49 ` Benjamin Herrenschmidt
2013-12-11 10:30 ` Philippe Bergheaud
2013-12-12 1:22 ` Michael Ellerman
2013-12-12 7:11 ` Philippe Bergheaud [this message]
2013-12-13 2:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A961A0.5010307@linux.vnet.ibm.com \
--to=felix@linux.vnet.ibm.com \
--cc=Linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).