From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: stewart@linux.vnet.ibm.com, j.anaszewski81@gmail.com,
cooloney@gmail.com, Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
rpurdie@rpsys.net, linux-leds@vger.kernel.org,
khandual@linux.vnet.ibm.com
Subject: Re: [PATCH v4 3/3] leds/powernv: Add driver for PowerNV platform
Date: Tue, 28 Apr 2015 12:18:22 +0200 [thread overview]
Message-ID: <5316346.zPr516JNgQ@wuerfel> (raw)
In-Reply-To: <20150428101008.26912.38735.stgit@localhost.localdomain>
On Tuesday 28 April 2015 15:40:35 Vasant Hegde wrote:
> +++ b/Documentation/devicetree/bindings/leds/leds-powernv.txt
> @@ -0,0 +1,29 @@
> +Device Tree binding for LEDs on IBM Power Systems
> +-------------------------------------------------
> +
> +The 'led' node under '/ibm,opal' lists service indicators available in the
> +system and their capabilities.
> +
> +led {
> + compatible = "ibm,opal-v3-led";
> + phandle = <0x1000006b>;
> + linux,phandle = <0x1000006b>;
> + led-mode = "lightpath";
> +
> + U78C9.001.RST0027-P1-C1 {
> + led-types = "identify", "fault";
> + led-loc = "descendent";
> + phandle = <0x1000006f>;
> + linux,phandle = <0x1000006f>;
> + };
> + ...
> + ...
> +};
We normally don't list the 'phandle' or 'linux,phandle' properties in the binding
description.
> +
> +Each node under 'led' node describes location code of FRU/Enclosure.
> +
> +The properties under each node:
> +
> + led-types : Supported LED types (attention/identify/fault).
> +
> + led-loc : enclosure/descendent(FRU) location code.
>
Could you use the standard 'label' property for this?
Arnd
next prev parent reply other threads:[~2015-04-28 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 10:09 [PATCH v4 0/3] LED interface for PowerNV platform Vasant Hegde
2015-04-28 10:09 ` [PATCH v4 1/3] powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states Vasant Hegde
2015-06-25 1:04 ` Benjamin Herrenschmidt
2015-04-28 10:10 ` [PATCH v4 2/3] powerpc/powernv: Create LED platform device Vasant Hegde
2015-06-25 1:05 ` Benjamin Herrenschmidt
2015-04-28 10:10 ` [PATCH v4 3/3] leds/powernv: Add driver for PowerNV platform Vasant Hegde
2015-04-28 10:18 ` Arnd Bergmann [this message]
2015-04-30 15:04 ` Vasant Hegde
2015-04-30 14:29 ` Jacek Anaszewski
2015-04-30 15:08 ` Vasant Hegde
2015-06-25 1:09 ` Benjamin Herrenschmidt
2015-06-26 5:17 ` Vasant Hegde
2015-06-11 6:33 ` [PATCH v4 0/3] LED interface " Vasant Hegde
2015-06-22 8:03 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5316346.zPr516JNgQ@wuerfel \
--to=arnd@arndb.de \
--cc=cooloney@gmail.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=j.anaszewski81@gmail.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rpurdie@rpsys.net \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).