From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp04.in.ibm.com (e28smtp04.in.ibm.com [122.248.162.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 63DD72C0084 for ; Fri, 21 Mar 2014 22:45:22 +1100 (EST) Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Mar 2014 17:15:20 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 16811125804D for ; Fri, 21 Mar 2014 17:17:39 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2LBjNHE4653548 for ; Fri, 21 Mar 2014 17:15:23 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2LBjGOi019705 for ; Fri, 21 Mar 2014 17:15:17 +0530 Message-ID: <532C263F.4090504@linux.vnet.ibm.com> Date: Fri, 21 Mar 2014 17:15:03 +0530 From: "Srivatsa S. Bhat" MIME-Version: 1.0 To: Viresh Kumar Subject: Re: [PATCH v3 1/5] powernv: cpufreq driver for powernv platform References: <1395317460-14811-1-git-send-email-ego@linux.vnet.ibm.com> <1395317460-14811-2-git-send-email-ego@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: "Gautham R. Shenoy" , Linux PM list , linuxppc-dev@ozlabs.org, Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/21/2014 02:11 PM, Viresh Kumar wrote: > On Thu, Mar 20, 2014 at 5:40 PM, Gautham R. Shenoy > wrote: >> From: Vaidyanathan Srinivasan > > Hi Vaidy, > >> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig >> index 4b029c0..4ba1632 100644 >> --- a/drivers/cpufreq/Kconfig >> +++ b/drivers/cpufreq/Kconfig >> @@ -48,6 +48,7 @@ config CPU_FREQ_STAT_DETAILS >> choice [...] >> +static struct cpufreq_driver powernv_cpufreq_driver = { >> + .verify = powernv_cpufreq_verify, >> + .target = powernv_cpufreq_target, > > I think you have Srivatsa there who has seen lots of cpufreq code and > could have helped you a lot :) > :-) I have followed the locking and synchronization aspects of cpufreq closely, but unfortunately, I haven't been able to keep up with some of the other details that well :-( Besides, its hard to keep up with the rate of your changes, you are way too fast! ;-) Regards, Srivatsa S. Bhat