From: Hongbo Zhang <hongbo.zhang@freescale.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Vinod Koul <vkoul@infradead.org>,
linux-kernel@vger.kernel.org, scottwood@freescale.com,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave
Date: Thu, 3 Apr 2014 15:00:02 +0800 [thread overview]
Message-ID: <533D06F2.7080702@freescale.com> (raw)
In-Reply-To: <20140402163519.GU1976@intel.com>
On 04/03/2014 12:35 AM, Vinod Koul wrote:
> On Mon, Mar 31, 2014 at 12:08:55PM +0800, Hongbo Zhang wrote:
>> On 03/29/2014 09:45 PM, Vinod Koul wrote:
>>> On Fri, Mar 28, 2014 at 02:33:37PM +0800, Hongbo Zhang wrote:
>>>> On 03/26/2014 03:01 PM, Vinod Koul wrote:
>>>>> On Thu, 2014-01-16 at 13:47 +0800, hongbo.zhang@freescale.com wrote:
>>>>>> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>>>>>>
>>>>>> The usage of spin_lock_irqsave() is a stronger locking mechanism than is
>>>>>> required throughout the driver. The minimum locking required should be used
>>>>>> instead. Interrupts will be turned off and context will be saved, it is
>>>>>> unnecessary to use irqsave.
>>>>>>
>>>>>> This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All
>>>>>> manipulation of protected fields is done using tasklet context or weaker, which
>>>>>> makes spin_lock_bh() the correct choice.
>>>>>>
>>>>>> /**
>>>>>> @@ -1124,11 +1120,10 @@ static irqreturn_t fsldma_chan_irq(int irq, void *data)
>>>>>> static void dma_do_tasklet(unsigned long data)
>>>>>> {
>>>>>> struct fsldma_chan *chan = (struct fsldma_chan *)data;
>>>>>> - unsigned long flags;
>>>>>> chan_dbg(chan, "tasklet entry\n");
>>>>>> - spin_lock_irqsave(&chan->desc_lock, flags);
>>>>>> + spin_lock_bh(&chan->desc_lock);
>>>>> okay here is the problem :(
>>>>>
>>>>> You moved to _bh variant. So if you grab the lock in rest of the code
>>>>> and irq gets triggered then here we will be spinning to grab the lock.
>>>>> So effectively you made right locking solution into deadlock situation!
>>>> If the rest code grabs lock by spin_lock_bh(), and if irq raised,
>>>> the tasklet could not be executed because it has been disabled by
>>>> the _bh variant function.
>>> yes if you are accessing resources only in tasklet and rest of the code, then
>>> _bh variant works well. The problem here is usage in irq handler
>>>
>> The name dma_do_tasklet may mislead, it is tasklet handler, not irq
>> handler, not a trigger to load tasklet.
>> the irq handler is fsldma_chan_irq, and I don't use lock in it.
> sorry my bad, i misread this as code in fsldma_chan_irq() insteadof
> dma_do_tasklet(). In that case patch is doing the right thing.
>
OK, so I will send a v2 series with only updating 3/7 soon.
next prev parent reply other threads:[~2014-04-03 7:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 5:47 [PATCH 0/7] DMA: Freescale: driver cleanups and enhancements hongbo.zhang
2014-01-16 5:47 ` [PATCH 1/7] DMA: Freescale: unify register access methods hongbo.zhang
2014-01-16 5:47 ` [PATCH 2/7] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine hongbo.zhang
2014-01-16 5:47 ` [PATCH 3/7] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication hongbo.zhang
2014-03-11 11:06 ` Vinod Koul
2014-03-28 3:44 ` Hongbo Zhang
2014-04-03 8:09 ` Hongbo Zhang
2014-01-16 5:47 ` [PATCH 4/7] DMA: Freescale: move functions to avoid forward declarations hongbo.zhang
2014-01-16 5:47 ` [PATCH 5/7] DMA: Freescale: change descriptor release process for supporting async_tx hongbo.zhang
2014-01-16 5:47 ` [PATCH 6/7] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave hongbo.zhang
2014-03-26 7:01 ` Vinod Koul
2014-03-28 6:33 ` Hongbo Zhang
2014-03-29 13:45 ` Vinod Koul
2014-03-31 4:08 ` Hongbo Zhang
2014-04-02 16:35 ` Vinod Koul
2014-04-03 7:00 ` Hongbo Zhang [this message]
2014-01-16 5:47 ` [PATCH 7/7] DMA: Freescale: add suspend resume functions for DMA driver hongbo.zhang
2014-02-26 7:38 ` [PATCH 0/7] DMA: Freescale: driver cleanups and enhancements Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D06F2.7080702@freescale.com \
--to=hongbo.zhang@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=vinod.koul@intel.com \
--cc=vkoul@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).