From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, riel@redhat.com,
rusty@rustcorp.com.au, dave.hansen@intel.com,
peterz@infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ak@linux.intel.com, paulus@samba.org, mgorman@suse.de,
linuxppc-dev@lists.ozlabs.org, mingo@kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries
Date: Tue, 20 May 2014 13:33:58 +0530 [thread overview]
Message-ID: <537B0C6E.4030501@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140520002834.aefb5a90.akpm@linux-foundation.org>
On Tuesday 20 May 2014 12:58 PM, Andrew Morton wrote:
> On Thu, 8 May 2014 14:58:16 +0530 Madhavan Srinivasan <maddy@linux.vnet.ibm.com> wrote:
>
>> --- a/arch/powerpc/platforms/pseries/pseries.h
>> +++ b/arch/powerpc/platforms/pseries/pseries.h
>> @@ -17,6 +17,8 @@ struct device_node;
>> extern void request_event_sources_irqs(struct device_node *np,
>> irq_handler_t handler, const char *name);
>>
>> +extern unsigned int fault_around_order;
>
> This isn't an appropriate header file for exporting something from core
> mm - what happens if arch/mn10300 wants it?.
>
> I guess include/linux/mm.h is the place.
>
Rusty already suggested this. My bad. Reason for adding it here was
that, I did the performance test for this platform. Will change and send
it out.
Thanks for review
Regards
Maddy
next prev parent reply other threads:[~2014-05-20 8:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 9:28 [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 1/2] mm: move FAULT_AROUND_ORDER to arch/ Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries Madhavan Srinivasan
2014-05-20 7:28 ` Andrew Morton
2014-05-20 8:03 ` Madhavan Srinivasan [this message]
2014-05-15 8:25 ` [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-15 17:28 ` Hugh Dickins
2014-05-19 0:12 ` Rusty Russell
2014-05-19 3:05 ` Madhavan Srinivasan
2014-05-19 23:23 ` Hugh Dickins
2014-05-19 23:43 ` Andrew Morton
2014-05-20 0:44 ` Kirill A. Shutemov
2014-05-20 6:22 ` Rusty Russell
2014-05-20 7:32 ` Andrew Morton
2014-05-20 7:53 ` Madhavan Srinivasan
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 19:59 ` Andrew Morton
2014-05-21 13:40 ` Kirill A. Shutemov
2014-05-21 20:34 ` Andrew Morton
2014-05-23 12:28 ` Kirill A. Shutemov
2014-05-27 6:24 ` Madhavan Srinivasan
2014-05-27 10:21 ` Kirill A. Shutemov
2014-05-27 10:44 ` Madhavan Srinivasan
2014-05-20 1:14 ` Rusty Russell
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:06 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B0C6E.4030501@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).